[FLINK-39531][table-planner] Fix duplicated Python UDF extraction in calc split rule#28037
Open
auroflow wants to merge 2 commits intoapache:masterfrom
Open
[FLINK-39531][table-planner] Fix duplicated Python UDF extraction in calc split rule#28037auroflow wants to merge 2 commits intoapache:masterfrom
auroflow wants to merge 2 commits intoapache:masterfrom
Conversation
Collaborator
Contributor
Author
|
@flinkbot run azure |
036f1a2 to
1a3daf5
Compare
cbfb52e to
81dd628
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Currently, ScalarFunctionSplitter bookkeeps extracted RexNodes to deduplicate identical remote functions during calc splitting, but the bookkeeping is keyed on the RexInputRef rather than the original RexNode. Therefore, when the same Python or Async UDF call appears in the input of multiple projections of one SELECT, each occurrence is extracted once and the UDF is invoked every time.
This PR solves this problem by making the bookkeeping keyed on the original RexNodes, not the RexInputRef.
Brief change log
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Opus 4.7