[FLINK-39532][python] Fix race condition in Python AsyncScalarFunctionOperation#28036
Open
auroflow wants to merge 1 commit intoapache:masterfrom
Open
[FLINK-39532][python] Fix race condition in Python AsyncScalarFunctionOperation#28036auroflow wants to merge 1 commit intoapache:masterfrom
auroflow wants to merge 1 commit intoapache:masterfrom
Conversation
Collaborator
8f3e7ea to
5e926d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Currently in AsyncScalarFunctionOperation, the process_element method submits the input value to an asyncio event loop and returns immediately. For flatten row, the input comes from FlattenRowCoderImpl.decode_from_stream. In the Cython implementation in coder_impl_fast.pyx, this method returns a reused list; by the time the async function runs, this reused list has already been overwritten by the next decoded row. This will make Python async UDFs receive wrong input values, causing corrupted results.
This pull request snapshots input flatten rows in Python AsyncScalarFunctionOperation to avoid race conditions.
Brief change log
Verifying this change
This change is verified by manually running SQL jobs containing Python async UDFs in a production cluster.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Opus 4.7