[FLINK-38902][docs] Add user instructions and usage documentation for FLIP-487#28003
[FLINK-38902][docs] Add user instructions and usage documentation for FLIP-487#28003RocMarshal wants to merge 4 commits intoapache:masterfrom
Conversation
spuru9
left a comment
There was a problem hiding this comment.
Can you apply the changes for chinese doc as well.
efce38d to
6d2a7cc
Compare
spuru9
left a comment
There was a problem hiding this comment.
Sorry, Missed a minor inconsistency.
Rest LGTM
| - `History` | ||
| This sub-page displays abbreviated information for the most recent `n` rescale records based on configuration. | ||
| Additionally, the page supports the display of detailed rescale information as outlined below: | ||
| - The basic information of the target rescale |
There was a problem hiding this comment.
do we need to say target rescale- can we just say rescale or are there other rescale types?
| - The basic information of the target rescale | ||
| - Rescale UUID: The unique ID in a rescale consists of 32 hexadecimal characters | ||
| - Attempt ID: The number ID of a rescale attempts that occurred under the same resource requirements | ||
| - Requirements ID: The unique ID of resource requirements consists of 32 hexadecimal characters |
There was a problem hiding this comment.
is this a UUID like the other one ?
There was a problem hiding this comment.
| - Requirements ID: The unique ID of resource requirements consists of 32 hexadecimal characters | ||
| - Trigger Cause: The reason that triggered the target rescale | ||
| - Terminal State: The end state of the target rescale | ||
| - Terminated Reason: The reason for the completion or termination of the target rescale |
There was a problem hiding this comment.
it talks of Terminated Reason which implies a termination, then in the wording in talks of completions and terminations as 2 different things. Implying that termination is an abnormal end.
| - Terminated Reason: The reason for the completion or termination of the target rescale | ||
| - Start Time: The start time of the target rescale | ||
| - Duration: Duration from the start of the rescale to its completion or until now | ||
| - End Time: The end time of the target rescale |
There was a problem hiding this comment.
I assume this is the same as Duration unless the rescale is ongoing
There was a problem hiding this comment.
consize.
And I had a try on a new description.
| - Start Time: The start time of the target rescale | ||
| - Duration: Duration from the start of the rescale to its completion or until now | ||
| - End Time: The end time of the target rescale | ||
| - The basic attributes and rescale change per `Job Vertex` |
There was a problem hiding this comment.
can we have a reference to Job vertex
There was a problem hiding this comment.
Thanks @davidradl
I have considered this issue before. To be honest, JobVertex is such a fundamental term that I didn’t add any external reference links.
Of course , if you think it's required, I'd like to try to added it.
| - Duration: Duration from the start of the rescale to its completion or until now | ||
| - End Time: The end time of the target rescale | ||
| - The basic attributes and rescale change per `Job Vertex` | ||
| - ID: The unique ID of target JobVertex consists of 32 hexadecimal characters |
There was a problem hiding this comment.
I assume JobVertx is the same as Job Vertex- I would suggest we are consistent.
There was a problem hiding this comment.
Yes, +1 from me.
| - Acquired Parallelism: The parallelism of target vertex after the current rescale | ||
| - Sufficient Parallelism: The minimal parallelism of target vertex to run | ||
| - Desired Parallelism: The desired parallelism of the target vertex | ||
| - The basic attributes and rescale change per `Slot Sharing Group` |
There was a problem hiding this comment.
I would say UUID - and define that once
| - Sufficient Slot: The minimal number of slots to deploy tasks in the rescale | ||
| - Request Profile: The request resource profile of the slot sharing group in the rescale | ||
| - Acquired Profile: The acquired resource profile of the slot sharing group in the rescale | ||
| - The internal `Scheduler State History` of `Adaptive Scheduler` within a rescale |
There was a problem hiding this comment.
Are the states documented?
There was a problem hiding this comment.
these states are an abstract representation of the scheduler's internal state; therefore, they were omitted to avoid introducing unnecessary ambiguity.
There was a problem hiding this comment.
I missed this comment. @davidradl has a point here. We could link to the StateMachine section of FLIP-160. That's where it is documented.
| - State: The scheduler state name | ||
| - Enter Time: The time to enter the state | ||
| - Leave Time: The time to leave the state | ||
| - Duration: Time spent in the state (Leave Time − Enter Time) |
There was a problem hiding this comment.
does this include the current state which will not have an end time?
There was a problem hiding this comment.
this doesn't include the current state which will not have an end time.
This is determined by the collection mechanism of adaptive state. Simply put, when a rescale adds a state, that state already includes start and end times.
| - Enter Time: The time to enter the state | ||
| - Leave Time: The time to leave the state | ||
| - Duration: Time spent in the state (Leave Time − Enter Time) | ||
| - Exception: The exception information about current rescale during the state |
There was a problem hiding this comment.
what does during the state mean?
There was a problem hiding this comment.
maybe during-> within?
| This sub-page displays the total number of rescale events that have occurred since the job was launched, | ||
| along with the respective counts of failures and successes. | ||
| Additionally, it provides statistical summaries of the rescale history, | ||
| such as rescale duration statistics categorized by rescale status, including `Min`, `Max`, `Avg`, and `Pnn` metrics. |
|
This PR hasn’t received any new comments for four days. If this continues, I plan to merge it on Tuesday. |
… FLIP-487 Co-authored-by: spuru9 <sinhapurushottam911@gmail.com> Co-authored-by: XComp <mpohl@confluent.io> Co-authored-by: davidradl <david_radley@uk.ibm.com>
|
Thank you @XComp very much for your review. |
What is the purpose of the change
[FLINK-38902][docs] Add user instructions and usage documentation for FLIP-487
Brief change log
[FLINK-38902][docs] Add user instructions and usage documentation for FLIP-487
Verifying this change
N.A
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation
Was generative AI tooling used to co-author this PR?