Use correct type of format strings when logging#103
Open
io7m wants to merge 10000 commits intoapache:trunkfrom
Open
Use correct type of format strings when logging#103io7m wants to merge 10000 commits intoapache:trunkfrom
io7m wants to merge 10000 commits intoapache:trunkfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing code uses SLF4J style logging strings, where the
string "{}" is expected to be formatted according to the given
arguments. Unfortunately, the format string is actually passed directly
to String.format() and therefore needs to use traditional Java style
format strings.