Fix Tupan test failures with numpy ≥2.4.0 (fixes #1256)#1258
Open
elkogerville wants to merge 6 commits intoamusecode:mainfrom
Open
Fix Tupan test failures with numpy ≥2.4.0 (fixes #1256)#1258elkogerville wants to merge 6 commits intoamusecode:mainfrom
elkogerville wants to merge 6 commits intoamusecode:mainfrom
Conversation
…ere ndarrays of dim 0 instead of floats
…d commit_particles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1256
Problem:
Tupan tests fail with numpy ≥2.4.0 due to incompatible dtype handling in
commit_particles. The method was assigning 0-dimensional np.ndarray objects toParticleSystemattributes instead of scalars.Solution: Refactored particle management to use amuse.datamodel.particle module.
new_particle: Changed to instantiateParticleobjects and accumulate them in aParticlesobject (instead of creating single-elementParticleSysteminstances)commit_particles: Convert the accumulatedParticlesobject to aParticleSystembefore passing to TupanTest Status:
All uncommented tests pass. Tests
xtest04,xtest08,xtest10remain commented because they test unimplemented features (stopping conditions,get_gravity_at_point).Additional Changes:
get_etaandset_etafrom Tupan methods as they are already defined as parameters.