Skip to content

Update: sys info printouts#190

Merged
alexandraBara merged 4 commits intodevelopmentfrom
alex_sku
Apr 27, 2026
Merged

Update: sys info printouts#190
alexandraBara merged 4 commits intodevelopmentfrom
alex_sku

Conversation

@alexandraBara
Copy link
Copy Markdown
Collaborator

@alexandraBara alexandraBara commented Apr 24, 2026

Summary

Only printing SKU/platform when populated, to avoid confusion when None. These items are input from user not information acquired from system.

Test plan

  • pytest test/unit
  • pytest test/functional (if applicable)
  • pre-commit run --all-files

Checklist

  • Added/updated tests (or explained why not)
  • Updated docs/README if behavior changed
  • No secrets or credentials committed

Before:

(venv) alexbara@ausalexbara02:~/node-scraper_public$ node-scraper run-plugins MemoryPlugin
  2026-04-24 07:53:11 CDT       INFO               nodescraper | Log path: ./scraper_logs_ausalexbara02_2026_04_24-07_53_11_AM
  2026-04-24 07:53:11 CDT       INFO               nodescraper | System Name: ausalexbara02
  2026-04-24 07:53:11 CDT       INFO               nodescraper | System SKU: None
  2026-04-24 07:53:11 CDT       INFO               nodescraper | System Platform: None
  2026-04-24 07:53:11 CDT       INFO               nodescraper | System location: SystemLocation.LOCAL
  2026-04-24 07:53:11 CDT       INFO               nodescraper | Initializing connection manager for InBandConnectionManager with default args 

After:

(venv) alexbara@ausalexbara02:~/node-scraper_public$ node-scraper run-plugins MemoryPlugin
  2026-04-24 07:54:43 CDT       INFO               nodescraper | Log path: ./scraper_logs_ausalexbara02_2026_04_24-07_54_43_AM
  2026-04-24 07:54:43 CDT       INFO               nodescraper | System Name: ausalexbara02
  2026-04-24 07:54:43 CDT       INFO               nodescraper | System location: SystemLocation.LOCAL
  2026-04-24 07:54:43 CDT       INFO               nodescraper | Initializing connection manager for InBandConnectionManager with default args  

@alexandraBara alexandraBara merged commit fba3bc8 into development Apr 27, 2026
6 of 10 checks passed
@alexandraBara alexandraBara deleted the alex_sku branch April 27, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant