Remove pytest_plugin#10762
Draft
Dreamsorcerer wants to merge 257 commits intomasterfrom
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10762 +/- ##
==========================================
+ Coverage 98.92% 98.94% +0.01%
==========================================
Files 134 131 -3
Lines 46750 46517 -233
Branches 2429 2409 -20
==========================================
- Hits 46248 46025 -223
+ Misses 373 367 -6
+ Partials 129 125 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
|
Missing change log? |
for more information, see https://pre-commit.ci
… drop-pytest-plugin
for more information, see https://pre-commit.ci
… drop-pytest-plugin
for more information, see https://pre-commit.ci
… drop-pytest-plugin
for more information, see https://pre-commit.ci
webknjaz
reviewed
Apr 22, 2025
|
|
||
|
|
||
| pytest_plugins = ("aiohttp.pytest_plugin", "pytester") | ||
| pytest_plugins = ("pytest_asyncio", "pytest_aiohttp", "pytester") |
Member
There was a problem hiding this comment.
Suggested change
| pytest_plugins = ("pytest_asyncio", "pytest_aiohttp", "pytester") | |
| pytest_plugins = ("pytester",) |
Member
Author
There was a problem hiding this comment.
I originally intended to add pytest_aiohttp to enforce it as a required plugin. Might help downstream packagers avoid getting confused by the change.
Member
There was a problem hiding this comment.
Or we could just add a changelog fragment..
Member
Author
There was a problem hiding this comment.
Or we could do both...
Member
There was a problem hiding this comment.
Just add a code comment explaining the motivation.
for more information, see https://pre-commit.ci
… drop-pytest-plugin
for more information, see https://pre-commit.ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
for more information, see https://pre-commit.ci
Dreamsorcerer
commented
May 9, 2026
Dreamsorcerer
commented
May 9, 2026
Dreamsorcerer
commented
May 9, 2026
Dreamsorcerer
commented
May 9, 2026
Dreamsorcerer
commented
May 9, 2026
Dreamsorcerer
commented
May 9, 2026
Co-authored-by: Sam Bull <aa6bs0@sambull.org>
Dreamsorcerer
commented
May 9, 2026
Dreamsorcerer
commented
May 9, 2026
Refactor aiohttp_client_sync fixture to remove overloads and simplify request type handling.
| server = TestServer(__param, **server_kwargs) | ||
| client = aiohttp_client_cls(server, **kwargs) | ||
|
|
||
| await client.start_server() |
|
|
||
| import asyncio | ||
| from collections.abc import Iterator | ||
| from typing import Any, TypeVar |
| server = TestServer(__param, **server_kwargs) | ||
| client = aiohttp_client_cls(server, **kwargs) | ||
|
|
||
| await client.start_server() |
Dreamsorcerer
commented
May 9, 2026
Removed cleanup fixture for pending file close operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be maintained exclusively in pytest-aiohttp going forwards.