Make Consumer and Producer dyn-compatible#53
Open
mincomk wants to merge 1 commit intoagerasev:masterfrom
Open
Conversation
agerasev
force-pushed
the
master
branch
2 times, most recently
from
ce05351 to
ff8b4c9
Compare
agerasev
reviewed
May 3, 2026
Comment on lines
+194
to
+205
| fn push_iter<I: Iterator<Item = Self::Item>>(&mut self, iter: I) -> usize | ||
| where | ||
| Self: Sized, | ||
| { | ||
| let mut count = 0; | ||
| for item in iter { | ||
| if self.try_push(item).is_err() { | ||
| break; | ||
| } | ||
| count += 1; | ||
| } | ||
| count |
Owner
There was a problem hiding this comment.
This change breaks push_iter implementation because next item still removed from iterator even if there's no free space in the buffer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
ConsumerandProducerdyn-compatibleI've made the two main traits in the crate:
ConsumerandProducerdyn-compatible by making iter-related methods explicitly non-dispatchable.There may be a performance issue caused by manual
push_iterinProducer, but it would be minor.