fix(evaluators): handle invalid unicode in detect-secrets evaluator#197
Closed
lan17 wants to merge 1 commit intofeature/detect-secrets-evaluatorfrom
Closed
fix(evaluators): handle invalid unicode in detect-secrets evaluator#197lan17 wants to merge 1 commit intofeature/detect-secrets-evaluatorfrom
lan17 wants to merge 1 commit intofeature/detect-secrets-evaluatorfrom
Conversation
lan17
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
auto-merge was automatically disabled
April 25, 2026 04:58
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- route UTF-8 encoding failures through the evaluator's normalization error path\n- add a regression test for lone surrogate input under on_error="deny"\n\n## Validation\n- make check (evaluators/contrib/detect_secrets)