feat(sdk): forward target_type and target_id on evaluation calls (5/7)#183
Draft
abhinav-galileo wants to merge 1 commit intoabhi/rfc-1-1-pr4-tenant-aware-writesfrom
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
4 tasks
abhinav-galileo
force-pushed
the
abhi/rfc-1-1-pr4-tenant-aware-writes
branch
from
0c1787e to
2532c58
Compare
abhinav-galileo
force-pushed
the
abhi/rfc-1-1-pr5-python-sdk-target
branch
from
d6c4da5 to
8652936
Compare
abhinav-galileo
force-pushed
the
abhi/rfc-1-1-pr4-tenant-aware-writes
branch
from
2532c58 to
0bc87a8
Compare
abhinav-galileo
force-pushed
the
abhi/rfc-1-1-pr5-python-sdk-target
branch
from
8652936 to
42fa1fb
Compare
Threads optional target_type / target_id through check_evaluation, check_evaluation_with_local, and evaluate_controls so callers can opt into target-bearing evaluation when the server supports it. Fields default to None so existing call sites are unchanged.
abhinav-galileo
force-pushed
the
abhi/rfc-1-1-pr4-tenant-aware-writes
branch
from
0bc87a8 to
5cb6d26
Compare
abhinav-galileo
force-pushed
the
abhi/rfc-1-1-pr5-python-sdk-target
branch
from
42fa1fb to
aa5acb0
Compare
abhinav-galileo
changed the title
4 tasks
abhinav-galileo
changed the title
abhinav-galileo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #182. Kept in draft until the full stack is validated.
Summary
Test plan