Skip to content

fix(contrast-colors): replace depreciated colorspace#281

Open
karim-semmoud wants to merge 4 commits into
adobe:mainfrom
karim-semmoud:fix-depreciated-colorspace
Open

fix(contrast-colors): replace depreciated colorspace#281
karim-semmoud wants to merge 4 commits into
adobe:mainfrom
karim-semmoud:fix-depreciated-colorspace

Conversation

@karim-semmoud
Copy link
Copy Markdown

@karim-semmoud karim-semmoud commented Mar 26, 2026

Description

This PR aims at replacing the depreciated use of colorspace in favor of colorSpace across Contrast Colors lib, test and documentation

Closes #280

Motivation

This allows a better developer experience by removing the depreciated log and lint message on the latest version

To-do list

  • I have read the CONTRIBUTING document.
  • Local test passes using moon
  • This pull request is ready to merge.

Note

Despite the colorspace still available for backward compatibility, the update of the README only refers to the latest colorSpace naming

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 26, 2026

🦋 Changeset detected

Latest commit: 4aff872

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@adobe/leonardo-contrast-colors Patch
@adobe/leonardo-mcp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@karim-semmoud karim-semmoud changed the title Fix(contrast-colors): replace depreciated colorspace fix(contrast-colors): replace depreciated colorspace Mar 26, 2026
Copy link
Copy Markdown
Author

@karim-semmoud karim-semmoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for CLI test to be approved and pass before marking this PR as "ready to merge"
Note: Test are passing locally with moon and ava

@danmizziharris
Copy link
Copy Markdown

@karim-semmoud thanks for working on this issue and PR. I found it because I was bumping into the same errors.

It looks like the checks have passed, once this has a changeset (to trigger a version bump) hopefully this will be good to go 🙇

Replaced deprecated colorspace in contrast colors.
@karim-semmoud
Copy link
Copy Markdown
Author

@danmizziharris You are very welcome, I love to work with Leonardo.
I just pushed a changeset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

backgroundcolor.js is using depreciated colorspace

2 participants