Skip to content

add support of active admin v4#5

Merged
Fivell merged 1 commit into
activeadmin-plugins:mainfrom
senid231:v4-support
Jun 1, 2026
Merged

add support of active admin v4#5
Fivell merged 1 commit into
activeadmin-plugins:mainfrom
senid231:v4-support

Conversation

@senid231
Copy link
Copy Markdown
Member

@senid231 senid231 commented Jun 1, 2026

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for ActiveAdmin v4 by introducing version-aware behavior (notably around the Devise login view override) and updating development/CI dependency stacks so the gem can be exercised against both the AA 3.5 and AA 4.0 lines.

Changes:

  • Add an ActiveAdmin::Oidc.aa_v4? version probe and use it to select AA4-compatible Tailwind login markup.
  • Split dependency stacks into per-version gemfiles and update CI to run specs against both stacks via BUNDLE_GEMFILE.
  • Broaden the gemspec ActiveAdmin dependency to < 5 and adjust ancillary repo config (.gitignore, Gemfile).

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
lib/generators/active_admin/oidc/install/templates/sessions_new.v4.html.erb New AA4-tailored login view template (Tailwind markup).
lib/generators/active_admin/oidc/install/install_generator.rb Selects which login view template to publish based on AA version.
lib/activeadmin-oidc.rb Introduces aa_v4? helper for AA version detection.
gemfiles/activeadmin_4.0.gemfile Defines the AA4/Rails 8/Tailwind development stack.
gemfiles/activeadmin_3.5.gemfile Defines the AA3.5/Rails 7.2/Sprockets development stack.
Gemfile Defaults local development to the AA3.5 gemfile via eval_gemfile.
app/views/active_admin/devise/sessions/new.html.erb Runtime AA3 vs AA4 branching for the login page markup.
activeadmin-oidc.gemspec Expands ActiveAdmin dependency to < 5; moves asset-stack deps out of gemspec.
.gitignore Ignores gemfile lockfiles and additional dummy app temp/log paths.
.github/workflows/ci.yml Switches CI to a gemfile-based matrix (AA3.5 + AA4.0).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib/activeadmin-oidc.rb
Comment thread lib/generators/active_admin/oidc/install/install_generator.rb
Comment thread .github/workflows/ci.yml
@senid231 senid231 force-pushed the v4-support branch 2 times, most recently from d2b2691 to d1ad65a Compare June 1, 2026 14:40
@senid231 senid231 requested a review from Copilot June 1, 2026 14:42
@Fivell Fivell merged commit 15e89a0 into activeadmin-plugins:main Jun 1, 2026
6 checks passed
@senid231 senid231 deleted the v4-support branch June 1, 2026 14:49
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants