Fix resolve_relative_url to handle multi-level relative paths#267
Open
voidpetal wants to merge 1 commit into
Open
Fix resolve_relative_url to handle multi-level relative paths#267voidpetal wants to merge 1 commit into
voidpetal wants to merge 1 commit into
Conversation
voidpetal
force-pushed
the
resolve-relative-url
branch
from
4e7f273 to
60187c1
Compare
Signed-off-by: Kai Hodžić <hodzic.e.k@outlook.com>
voidpetal
force-pushed
the
resolve-relative-url
branch
from
60187c1 to
c240fe3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve_relative_urlonly handled one level of../traversal. When a PyPI simple index returns hrefs with multiple../segments (e.g.../../packages/...), the function left literal../in the final URL, causing 404 errors on servers that don't normalize paths server-side.Replace the manual string manipulation with
urllib.parse.urljoin, which correctly resolves arbitrary../depth.