Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
m-hulbert
force-pushed
the
docs-nav-update
branch
3 times, most recently
from
7fd8d23 to
b72d35b
Compare
m-hulbert
force-pushed
the
docs-nav-update
branch
from
7d72699 to
80436c3
Compare
m-hulbert
force-pushed
the
docs-nav-update
branch
from
80436c3 to
84d8ce1
Compare
m-hulbert
force-pushed
the
docs-nav-update
branch
from
84d8ce1 to
21ac1f5
Compare
Replace the previous header navigation with three top-level tabs: Platform, Products, and Examples. Add a search button trigger with keyboard shortcut hint, Ask AI button, and help resources dropdown. Restructure the mobile menu with a tab-based layout where the Products tab keeps the ProductBar pinned above the scrollable sidebar. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add a sticky ProductBar for switching between products (Pub/Sub, Chat, Spaces, etc.) shown below the header on non-platform pages. Restructure the main layout from a centred container to a full-width flex layout with left sidebar, content pane (max 860px for docs, 1024px for examples), and right sidebar. Change button hover style from border colour to background fill. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Extract the copy-for-LLM functionality from PageHeader into a dedicated CopyForLLM component with a split button (copy action + dropdown for markdown preview, copy, and LLM links). Add ButtonGroup and Separator UI primitives. Simplify PageHeader after extraction. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Flatten the left sidebar to show a single product's nav with static section headings and accordion sub-menus. Move the language selector from the left sidebar to the right sidebar, restyle it as a bordered button matching the secondary button style. Add useShowLanguageSelector hook to determine visibility based on page languages. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ooks Extract the duplicated product bar visibility check into activePage.hasProductBar, computed once in the layout context. Simplify useShowLanguageSelector double negation to the equivalent some(). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Restructure nav data for all products to use section-based grouping with Getting started sections. Update generateMarkdownFooter test to match the new section structure. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
m-hulbert
force-pushed
the
docs-nav-update
branch
from
21ac1f5 to
dd161f3
Compare
m-hulbert
changed the title
jamiehenson
left a comment
jamiehenson
left a comment
There was a problem hiding this comment.
I like it, it's close! Sat with it a little more since demo earlier. Code is decent. I like the simplifications, I like the break up of the utility bar and the shuffling round of various things. Product bar works well. Pretty minor stuff from here tbh and some of it is subjective.
Small observations:
- I understand why the left nav contents was padded in (to align with the ably logo and the product row), but it looks weird and overly big to me, particularly when the padding between elements is so small. Honestly, I'd lower the side and top padding
- Product row on mobile looks a bit padded in as well, weird when scrolling
| @@ -0,0 +1,18 @@ | |||
| import { useMemo } from 'react'; | |||
There was a problem hiding this comment.
I don't think this needs to be its own hook, it is only used in one place - best to localise this to where it's used.
| </div> | ||
| <Tooltip.Provider delayDuration={0} disableHoverableContent> | ||
| <div className="hidden md:flex gap-2 pt-3 md:py-0 px-4 md:px-0 shrink-0"> | ||
| <button |
There was a problem hiding this comment.
From what I can see this Ask AI button is no longer gated by inkeepChatEnabled - sounds like a problem, unless it's now on everywhere all the time without the switch
| @@ -0,0 +1,131 @@ | |||
| import { useMemo } from 'react'; | |||
| setCopyFeedback('Error!'); | ||
| } | ||
|
|
||
| setTimeout(() => setCopyFeedback(null), 2000); |
There was a problem hiding this comment.
If the user navigates within 2s of clicking copy, this fires setState on an unmounted component. Minor; the abortController pattern already used for the fetch is the right model to extend here (or keep a ref and clearTimeout on unmount).
|
|
||
| const pageLayoutOptions: Record<string, LayoutOptions> = { | ||
| '/docs': { leftSidebar: true, rightSidebar: false, template: 'index', mdx: false }, | ||
| '/docs': { leftSidebar: false, rightSidebar: false, template: 'index', mdx: false }, |
There was a problem hiding this comment.
No left bar on the homepage?
| <> | ||
| <div className="h-[2.125rem] sm:h-[1.875rem] w-5 absolute left-2 top-1 flex items-center justify-center select-none cursor-default"> | ||
| <Icon name={'icon-gui-magnifying-glass-outline'} size="1rem" /> | ||
| <div className="relative w-full"> |
There was a problem hiding this comment.
Cool but is this in scope with the rest of the PR feature?
| return [ | ||
| { model: 'gpt', label: 'Open in ChatGPT', icon: 'icon-tech-openai', link: gptPath }, | ||
| { model: 'claude', label: 'Open in Claude', icon: 'icon-tech-claude-mono', link: claudePath }, | ||
| { model: 'perplexity', label: 'Open in Perplexity', icon: 'icon-tech-perplexity', link: perplexityPath }, |
There was a problem hiding this comment.
Not seeing a logo for this on the review app - package bump? I know you were asking about this before
3 participants
Description
This PR updates the docs navigation;