ci: staged-release pipeline with deployed-URL E2E gate, prod smoke, and rollback (ADR-0001)#791
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
…nd rollback (ADR-0001)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imitates conf-app's transferable release practices on the Firebase stack (not its Cloudflare/Forge mechanics). Motivated by the recent risky prod deploy that spawned
rollback-prod. Full rationale + rejected alternatives indocs/adr/0001-release-pipeline-imitating-conf-app.md.New flow
Changes
playwright.config.js—PW_BASE_URLenv + conditionalwebServer; one spec serves local / staging-gate / prod-smoke.e2e/tests/smoke.spec.js— tag a fast read-only@smokesubset (load + render + core-bundle).deploy-staging.yml— restrict to master+PRs, never-cancel-master concurrency, staging E2E gate, auto-draft release.deploy-prod.yml— post-deploy@smokejob against production.rollback-prod.yml(new) —workflow_dispatchre-deploys a chosen priorrelease-*across all surfaces (hosting + functions + Firestore rules), with post-rollback smoke.Key decision: deployed-URL gate is chromium-only
Verified against live staging: the full 3-browser suite has webkit hard-fail + firefox flakiness on network-timed localStorage/render tests (a remote-target artifact — the 3-browser suite is green locally on PRs). Scoping the deployed gate to chromium keeps "did the deploy work?" reliable without blocking every release on cross-browser flake. Cross-browser correctness stays covered by the local PR run.
Verification (local)
@smokeselects 9 (3×3), full suite 96; env toggle confirmed (local→localhost+webServer, remote→URL+no webServer).@smokegreen against live prod (chromium, 3 passed, 5.6s).Not verifiable without a real Actions run: deploy steps,
gh release create, artifact pass-through, concurrency behavior — these first exercise on merge to master.actionlintnot installed locally.🤖 Generated with Claude Code