Release 1.0.0-rc.1: ship 1.0 features and relocate FastTools/

[VPDPersonal]

First release candidate for Aspid.FastTools 1.0.0 — published as com.aspid.fasttools 1.0.0-rc.1. The package was renamed from Aspid.UnityFastTools, restructured into a Unity package + standalone generators solution, and got a large feature pass.

The ID System stays marketed as beta — its public API, generated boilerplate and editor workflow may still change before the final 1.0.0 release.

Source generators

ProfilerMarkersGenerator emits a ProfilerMarker per this.Marker() call site, keyed by enclosing type / member / line — supports .WithName(literal) and $"...". IdStructGenerator emits IId boilerplate for partial structs marked with [UniqueId], and reports AFID001 / AFID002 when the struct isn't partial or already declares the generated members. Pipeline data is value-equatable to keep Roslyn's incremental cache stable (regression-tested).

ID System (beta)

A single IdRegistry (ScriptableObject) maps names ↔ stable integer IDs for a given IId struct. IdRegistryResolver lazily indexes Type AQN → registry and updates incrementally via AssetPostprocessor. The inspector (RegistryEditorCore) does C#-identifier validation, full Undo, an explicit Review / Clean-up flow, Sort/Group toolbar, and a manual Next ID with a backward-step warning. There's also an IdField VisualElement and an Open-Registry shortcut on the IdStruct drawer.

Types & Enums

SerializableType / SerializableType<T> serialize System.Type via assembly-qualified names with lazy resolution; TypeSelectorWindow is the shared IMGUI/UIToolkit picker. ComponentTypeSelectorAttribute and the TypeAllow enum tighten what can be picked. EnumValues<TValue> is a serializable enum→value dictionary with [Flags] support and a populate-missing context menu.

UIToolkit

Large fluent API over VisualElement covering layout, sizing, IStyle, USS, child management, callbacks, IBindable, and per-element extensions (Image, Button, Foldout, HelpBox, List, ProgressBar, Slider, TextElement, Field, IMGUIContainer, INotifyValueChanged, manipulators, PropertyField). An optional Aspid.FastTools.Unity.VisualElements.Math satellite assembly adds INotifyValueChanged extensions for float2/3/4 and int2/3/4, gated by com.unity.mathematics through versionDefines.

Internal editor components

AspidLabel, AspidBox, AspidGradientButton, AspidHelpBox, AspidInspectorHeader, AspidAnimatedLogo, AspidAnimatedTitle, AspidAnimatedDotsBackground, AspidDividingLine, AspidHoverGradientOverlay — each with a fluent Preset and USS-driven custom style properties. Shared helpers (AspidStyles, StatusStyle, ThemeStyle, InlineStyle<T>, ICustomStyleExtensions) live next to them.

Editor utilities

Fluent SerializedProperty extensions, VerticalScope / HorizontalScope / ScrollViewScope, MonoScript.GetScriptName(WithIndex), and a WelcomeWindow (Tools → Aspid FastTools → Welcome) that reads package.json to install samples.

Design system

BRANDBOOK.html documents the palette, H1–H7 type scale and the 10 internal components. USS classes follow BEM (aspid-fasttools-{block}__{element}--{modifier}); custom properties follow a positional grammar (--{prefix}-{group}-{role}[-{state}][-{tone}]).

Samples

Under Samples~/ (UPM convention): Types, EnumValues, Ids, ProfilerMarkers, VisualElements.

Layout & rename

Folders renamed from Aspid.UnityFastTools(.Generators) to Aspid.FastTools(.Generators). Public API moved into Aspid.FastTools.{Types,Enums,Ids,UIElements,Editors}. Assemblies split into Aspid.FastTools (pure C#), Aspid.FastTools.Unity (runtime), the Mathematics satellite, and Aspid.FastTools.Unity.Editor.

Docs & tooling

Synced README.md / README_RU.md (root + Documentation/), DESIGN.md, CLAUDE.md. The Aspid.Claude.Plugins marketplace is documented in the READMEs, and there's local Claude Code automation — a PostToolUse hook that rebuilds the generators DLL on edits, plus the build-generator / sync-readmes / commit / open-pr skills and code-reviewer / uss-bem-checker subagents.

Release-candidate polish

• Relocated the package contents from Assets/Aspid/Plugins/FastTools to Assets/Aspid/FastTools and updated every internal path reference; the UPM install URL example in all four READMEs now points at the new path=Aspid.FastTools/Assets/Aspid/FastTools and the 1.0.0-rc.1 tag.
• Renamed the Welcome window class.
• Synced DESIGN.md to Unity 6.0+ and bumped it to v1.2.0.
• Filled out package.json with license, URLs, keywords and the Unity 6.0+ target.
• Actualised CHANGELOG.md for the release and renamed its [1.0.0] section to [1.0.0-rc.1] — 2026-05-18.
• Bumped package.json version to 1.0.0-rc.1.
• Resized status icons to 1022×1011 and dropped the unused open_button_icon resource.
• Dropped the .unitypackage install option from READMEs (UPM only).

Notes for review

• This PR is the release-cut vehicle for 1.0.0-rc.1. Kept as draft + status: work-in-progress until the RC is ready to be tagged on main.
• The folder relocation (Plugins/FastTools → FastTools) dominates the diff statistically but is path-only; verify the package.json path= example resolves on UPM and that Unity opens the project from a clean import.
• Generator tests pass locally (dotnet test → 36/36).

Linked issues

Closes #9
Closes #11

[VPDPersonal]

@claude please review this PR

[claude]

Claude finished @VPDPersonal's task in 5m 46s —— View job

---

PR Review — Release 1.0

• Read CLAUDE.md and repo guidelines
• Check status of issues flagged in the previous review
• Review source generators (ProfilerMarkers, IdStruct)
• Review Unity/Editor assembly boundary
• Review ID System public API
• Review UIToolkit fluent API
• Review USS/BEM naming conventions
• Post final review summary

---

Previous-review fixes — all three resolved ✅

Issue	Status
IsCacheDirty / player build empty registry	✅ Fixed — OnEnable() => IsCacheDirty = true added (IdRegistry.cs:47)
GetKeyword throws InvalidOperationException on unknown TypeKind	✅ Fixed — _ => "class" fallback added (IdStructData.cs:67)
USS gradient button property names (gradient-button-* → gradient_button-*)	✅ Fixed — USS and AspidGradientButtonColorsStyle.cs both updated

The static event memory leak concern from the previous review is also non-issue: there is exactly one subscriber, IdStructUIToolkitPropertyDrawer.cs:30–31, which correctly gates the subscription with AttachToPanelEvent / DetachFromPanelEvent. No exposed leak path.

---

Generator correctness ✅

Incremental cache — IncrementalCacheTests guards the pipeline for both generators. Every data struct is a readonly struct with explicit IEquatable<T> over all fields, including element-wise comparison for ImmutableArray<ContainingTypeInfo>. No ISymbol or SyntaxNode is stored in any pipeline data struct.

ProfilerMarkersGenerator — The field-name scheme {methodName}_Marker_Line_{line} is correct (MarkerCall.cs:22: MarkerName = markerName + "_Marker_Line_" + line). The line-based dispatch in AppendWithoutMessage is sound because the caller passes [CallerLineNumber] which is unique per call site in the file. The #if ENABLE_PROFILER gate means non-development player builds pay no per-call dispatch cost.

IdStructGenerator — The Predicate → Transform → Emit pipeline is clean. AFID001 / AFID002 diagnostics fire before body generation and prevent malformed partial-less or already-declared output. The .Where(static r => !r.IsEmpty) filter prevents empty results from reaching RegisterSourceOutput.

IdStructBody — Generates [SerializeField] private int _id and public int Id => _id unconditionally (correct — SerializeField is UnityEngine, not UnityEditor), and gates __stringId behind #if UNITY_EDITOR. Hint name includes {Namespace}.{ContainingChain}{StructName}{_Arity?}.IId.g.cs, unique across same-name structs in different namespaces or nesting depths.

---

Assembly boundary ✅

Aspid.FastTools.Unity.asmdef has no UnityEditor reference. The two SetUnityEditorTextRenderingMode hits in VisualElementExtensions.Style.cs and IStyleExtensions.cs are UIToolkit IStyle property names, not editor assembly imports. IdRegistry.Editor.cs is correctly gated with #if UNITY_EDITOR.

---

ID System API

Registry resolver — IdRegistryResolver.Find / Create / GetOrCreate correctly enforce one-registry-per-type via the _byAqn cache. OnAssetImported handles incremental updates. Duplicate detection logs errors correctly. The Create path has a minor redundancy: SaveAssets() triggers OnAssetImported which sets _byAqn[aqn] = registry, then the explicit _byAqn[aqn] = registry on line 55 sets it again. Harmless but could be removed.

Minor — Count vs GetEnumerator bound mismatch:

IdRegistry.cs:38 returns _ids.Length:

public int Count => _ids.Length;

IdRegistry.cs:87–93 iterates Math.Min(_ids.Length, _names.Length):

var count = Math.Min(_ids.Length, _names.Length);

The editor mutation path keeps both arrays in sync so this never fires in practice, but it's a latent inconsistency — a consumer using Count alongside foreach would silently see different bounds if the asset ever became corrupt. Low priority for 1.0, but worth aligning. Fix this →

Informational — IdRegistry<T> typed API: IdRegistry<T> is not documented in the samples or README. Consumers who discover it via autocomplete won't know they must declare the field as IdRegistry<EnemyId> in C# but drag in an untyped IdRegistry asset in the Inspector (Unity serialises it because IdRegistry<T> : IdRegistry : ScriptableObject). A single callout in the Ids sample or README.md would save confusion.

---

USS / BEM naming ✅

All checked stylesheets follow aspid-fasttools-{block}[__{element}][--{modifier}]. Custom properties in all checked files follow the --{prefix}-{group}-{role}[-{state}][-{tone}] positional grammar with _ for compound roles (gradient_button, label_size) and - as slot separators. The --aspid-colors-status-*-text-* 6-slot pattern (prefix-group-status-state-text-tone) is a consistently applied extension of the documented grammar.

---

Summary

Area	Status
Generator correctness & cache safety	✅ Solid
Assembly boundary	✅ Clean
ID System — runtime cache fix	✅ Fixed
USS / BEM naming	✅ Clean
IdRegistry.Count vs GetEnumerator	⚠️ Minor latent inconsistency
IdRegistry<T> discoverability	ℹ️ Informational

The one remaining minor item (Count vs GetEnumerator) is latent and low-risk. Everything critical from the May 10 review is resolved. The codebase is in solid shape for a 1.0 release.