find a minor bug, fix it and push a PR, you don't have to build and r...#1
Closed
ningcui-compass wants to merge 1 commit into
Closed
find a minor bug, fix it and push a PR, you don't have to build and r...#1ningcui-compass wants to merge 1 commit into
ningcui-compass wants to merge 1 commit into
Conversation
…tion and open a reviewed PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Goal
Find and fix one safe, minor bug in the gemini-cli repo, then open a reviewed PR. The task explicitly does NOT require building or running anything — the priority is a small, self-contained, unambiguously-correct fix that passes review and gets pushed.
Chosen bug
A duplicated word ("the the") in a test description string in
packages/cli/src/ui/hooks/slashCommandProcessor.test.tsxat line 456:This was verified by direct read and by grep — it is the only "the the " occurrence in
packages/. The fix is to remove the duplicate "the". This changes only a human-readable test title string (not assertion logic, not test behavior), so it is the lowest-risk possible change: no build/run needed to be confident it is correct, and Vitest test titles are arbitrary strings.Other candidates were considered (a logic off-by-one in
packages/core/src/utils/paths.ts, a capitalization inconsistency inpackages/core/src/tools/edit.ts, awkward grammar inpackages/cli/src/config/extension-manager.ts) but rejected for this task because they either touch real logic (riskier without running tests) or are more subjective. The duplicate-word typo is the clearest, safest choice given the "easy fix, no build/run" constraint.Repo conventions
packages/cli.google-gemini/gemini-cliupstream project; the working branch isharness/goldenWorkflow-1780498158882offmain.test:orfix:prefix is appropriate (e.g.fix(cli): correct duplicated word in test description).Workflow expectation
Implement the one-line edit, get it reviewed (e.g. via the local-review skill), commit on the current branch, and push a PR against
main. Do not bundle unrelated cleanup.Chunks
Metrics
Generated by temporal-harness