Relicense to 0BSD; fix StudentTCopula DF setter; harden download tests against outages#137
Merged
HadenSmith merged 2 commits intomainfrom Apr 27, 2026
Merged
Conversation
Replaces the BSD-3-Clause USACE-RMC license. Strips the license header from 378 .cs files and updates README, CITATION.cff, CONTRIBUTING.md, docs/index.md, codemeta.json, and Numerics.csproj NuGet metadata.
…tages StudentTCopula: DegreesOfFreedom setter no longer throws — it sets _parametersValid via the new ValidateParameters(rho, nu) and constructors follow suit. ValidateParameter now delegates to ValidateParameters so the base Theta setter validates both parameters. Unify the ν minimum on 2 + 1e-10 across ParameterConstraints and SetCopulaParameters; the previous 2.0 + Tools.DoubleMachineEpsilon expression silently rounded to 2.0 in IEEE 754 (ULP at 2.0 is 2^-51, larger than eps = 2^-53), making the optimizer fail at the boundary. Tests updated for the int→double widening and the new minimum. Test_TimeSeriesDownload: add per-service AvailableAsync probes (CHMN, USGS, GHCN, BOM) memoized via ConcurrentDictionary<string, Lazy<Task<bool>>>; replace `Online()` in all 31 integration tests so an upstream outage skips cleanly instead of failing CI. BOM URLs switched to https and 5xx response bodies are now surfaced in the exception so the next outage is self-documenting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.csfiles and updatesREADME,CITATION.cff,CONTRIBUTING.md,docs/index.md,codemeta.json, and the NuGet metadata inNumerics.csproj.DegreesOfFreedomsetter no longer throws — it now sets_parametersValidvia a newValidateParameters(rho, nu)method, matching theBivariateCopula.Theta/BetaDistributionconvention. Constructors stop guarding too. Also unifies the ν minimum on2 + 1e-10acrossParameterConstraintsandSetCopulaParameters— the previous2.0 + Tools.DoubleMachineEpsilonexpression silently rounded to2.0in IEEE 754, causing the optimizer to fail validation at the lower bound. Tests updated for theint → doubleDF widening.AvailableAsyncprobes (CHMN, USGS, GHCN, BOM) replace the genericOnline()check in all 31 integration tests so a single provider outage skips cleanly instead of failing CI. (Currently triggered by BOM's WDP backend returning500 DatasourceError.) BOM URLs switched tohttps://and 5xx response bodies are surfaced in exceptions so the next outage is self-documenting.