Fix tests specific to NodeNorm ES#76
Draft
gaurav wants to merge 13 commits into
Draft
Conversation
Tests that NodeNorm ES returns a valid dict for the specific ~300-CURIE list that was reported to cause failures. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…oducer. Three test shapes: all CURIEs minus the bad pair (passes), the minimal failing pair CHEBI:17310 + DRUGBANK:DB00058 (xfail), and each CURIE individually (all pass). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
UNII:2ZM8CX04RZ triggers HTTP 500 with drug_chemical_conflate=True on both ci and ci-biothings; passes with drug_chemical_conflate=False. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
NCBITaxon:2 returns null when queried alongside MESH:C029371, but succeeds alongside MESH:D008795 or on its own. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Asserts that equivalent_identifiers returned by /get_normalized_nodes for the three CURIEs in the issue (UMLS:C0106127, CHEMBL.COMPOUND:CHEMBL221542, PUBCHEM.COMPOUND:222284) contains no duplicate identifiers, and that the unique counts match the issue (17 without drug_chemical_conflate, 32 with). Currently fails on Redis backends with drug_chemical_conflate=true; passes on ES. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…e output Parametrize over each CURIE individually so failures are reported per-CURIE rather than grouped. Include a numbered list of equivalent_identifiers (with duplicate markers) in assertion messages so failures are self-explanatory without needing extra flags. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates tests that need to be modified for NodeNorm ElasticSearch.
WIP. Should be merged after PR #67.