feat: add meta binary search implementation#1894
Open
nickzerjeski wants to merge 4 commits intoTheAlgorithms:masterfrom
Open
feat: add meta binary search implementation#1894nickzerjeski wants to merge 4 commits intoTheAlgorithms:masterfrom
nickzerjeski wants to merge 4 commits intoTheAlgorithms:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new “Meta Binary Search” algorithm implementation to the Search/ algorithms collection, along with a dedicated Jest test suite, expanding coverage requested in #1835.
Changes:
- Added
metaBinarySearchimplementation inSearch/MetaBinarySearch.js. - Added Jest tests for numeric, string, missing-target, and empty-array cases in
Search/test/MetaBinarySearch.test.js.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Search/MetaBinarySearch.js | Introduces the meta binary search implementation and its public export. |
| Search/test/MetaBinarySearch.test.js | Adds a test suite validating core expected behavior for the new search algorithm. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
89dda91 to
0de1aa1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1894 +/- ##
==========================================
+ Coverage 85.91% 85.93% +0.01%
==========================================
Files 379 380 +1
Lines 19778 19806 +28
Branches 3016 3022 +6
==========================================
+ Hits 16993 17021 +28
Misses 2785 2785 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Author
|
@copilot apply changes based on the comments in this thread |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Added
Search/MetaBinarySearch.jswith tests inSearch/test/MetaBinarySearch.test.js.This contributes to the issue request for additional searching/sorting algorithm coverage.
Checklist:
Fixes: #{$ISSUE_NO}.Tests
npm test -- MetaBinarySearchFixes #1835