Skip to content

Secure fix missing para dbmodnet#4050

Merged
maliberty merged 21 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:secure-fix_missing_para_dbmodnet
May 21, 2026
Merged

Secure fix missing para dbmodnet#4050
maliberty merged 21 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:secure-fix_missing_para_dbmodnet

Conversation

@openroad-ci
Copy link
Copy Markdown
Collaborator

@openroad-ci openroad-ci commented Mar 25, 2026

This PR needs metric change due to now vieweing parasitics correctly on modnets. Corresponds to this PR in OpenROAD The-OpenROAD-Project/OpenROAD#9745

CI Could not Update Rules

[ERROR] sky130hd/jpeg: No metrics found, please check the latest CI build for issues.
[ERROR] sky130hd/microwatt: No metrics found, please check the latest CI build for issues.
[ERROR] sky130hd/riscv32i: No metrics found, please check the latest CI build for issues.
[ERROR] sky130hs/aes: No metrics found, please check the latest CI build for issues.
[ERROR] sky130hs/gcd: No metrics found, please check the latest CI build for issues.
[ERROR] sky130hs/ibex: No metrics found, please check the latest CI build for issues.
[ERROR] sky130hs/jpeg: No metrics found, please check the latest CI build for issues.
[ERROR] sky130hs/riscv32i: No metrics found, please check the latest CI build for issues.

CI Could not Update Rules

[ERROR] sky130hd/jpeg: No metrics found, please check the latest CI build for issues.
[ERROR] sky130hd/microwatt: No metrics found, please check the latest CI build for issues.
[ERROR] sky130hd/riscv32i: No metrics found, please check the latest CI build for issues.
[ERROR] sky130hs/aes: No metrics found, please check the latest CI build for issues.
[ERROR] sky130hs/gcd: No metrics found, please check the latest CI build for issues.
[ERROR] sky130hs/ibex: No metrics found, please check the latest CI build for issues.
[ERROR] sky130hs/jpeg: No metrics found, please check the latest CI build for issues.
[ERROR] sky130hs/riscv32i: No metrics found, please check the latest CI build for issues.

Updated Rules

[WARNING] Multiple clocks not supported. Will use first clock: mrx_clk_pad_i: 300.0000.
[WARNING] Multiple clocks not supported. Will use first clock: mrx_clk_pad_i: 300.0000.
[WARNING] Multiple clocks not supported. Will use first clock: clk: 333.0000.
designs/asap7/swerv_wrapper/rules-base.json updates:

Metric Old New Type
finish__timing__setup__ws -80.0 -319.0 Failing
finish__timing__setup__tns -320.0 -47000.0 Failing

[WARNING] Multiple clocks not supported. Will use first clock: clk_i: 3.0000.
designs/nangate45/swerv/rules-base.json updates:

Metric Old New Type
finish__timing__setup__tns -460.0 -619.0 Failing

designs/sky130hd/gcd/rules-base.json updates:

Metric Old New Type
finish__timing__setup__ws -1.74 -1.86 Failing
finish__timing__setup__tns -81.2 -87.8 Failing

[WARNING] Multiple clocks not supported. Will use first clock: ext_clk: 15.0000.
designs/sky130hd/microwatt/rules-base.json updates:

Metric Old New Type
finish__timing__setup__ws -1.34 -2.71 Failing
finish__timing__setup__tns -158.0 -337.0 Failing

Messages from CI

[INFO] asap7/minimal not included in CI.
[INFO] gf12 not included in the update.
[INFO] gf55 not included in the update.
[INFO] nangate45/bp_quad not included in CI.

Updated Rules

[WARNING] Multiple clocks not supported. Will use first clock: mrx_clk_pad_i: 300.0000.
[WARNING] Multiple clocks not supported. Will use first clock: mrx_clk_pad_i: 300.0000.
[WARNING] Multiple clocks not supported. Will use first clock: clk: 333.0000.
designs/asap7/swerv_wrapper/rules-base.json updates:

Metric Old New Type
finish__timing__setup__ws -80.0 -319.0 Failing
finish__timing__setup__tns -320.0 -47000.0 Failing

[WARNING] Multiple clocks not supported. Will use first clock: clk_i: 3.0000.
designs/nangate45/swerv/rules-base.json updates:

Metric Old New Type
finish__timing__setup__tns -459.0 -516.0 Failing

designs/nangate45/swerv_wrapper/rules-base.json updates:

Metric Old New Type
finish__timing__setup__tns -113.0 -127.0 Failing

designs/sky130hd/gcd/rules-base.json updates:

Metric Old New Type
finish__timing__setup__ws -1.74 -1.86 Failing
finish__timing__setup__tns -81.2 -87.8 Failing

[WARNING] Multiple clocks not supported. Will use first clock: ext_clk: 15.0000.
designs/sky130hd/microwatt/rules-base.json updates:

Metric Old New Type
finish__timing__setup__ws -1.34 -2.71 Failing
finish__timing__setup__tns -157.0 -336.0 Failing

designs/sky130hs/ibex/rules-base.json updates:

Metric Old New Type
globalroute__timing__setup__tns -7.77 -33.7 Failing

Messages from CI

[INFO] asap7/minimal not included in CI.
[INFO] gf12 not included in the update.
[INFO] gf55 not included in the update.
[INFO] nangate45/bp_quad not included in CI.

Updated Rules

[WARNING] Multiple clocks not supported. Will use first clock: mrx_clk_pad_i: 300.0000.
[WARNING] Multiple clocks not supported. Will use first clock: mrx_clk_pad_i: 300.0000.
[WARNING] Multiple clocks not supported. Will use first clock: clk: 333.0000.
designs/asap7/swerv_wrapper/rules-base.json updates:

Metric Old New Type
finish__timing__setup__ws -80.0 -319.0 Failing
finish__timing__setup__tns -320.0 -47000.0 Failing

[WARNING] Multiple clocks not supported. Will use first clock: clk_i: 3.0000.
designs/nangate45/swerv/rules-base.json updates:

Metric Old New Type
finish__timing__setup__tns -459.0 -516.0 Failing

designs/nangate45/swerv_wrapper/rules-base.json updates:

Metric Old New Type
finish__timing__setup__tns -113.0 -127.0 Failing

designs/sky130hd/gcd/rules-base.json updates:

Metric Old New Type
finish__timing__setup__ws -1.74 -1.86 Failing
finish__timing__setup__tns -81.2 -87.8 Failing

[WARNING] Multiple clocks not supported. Will use first clock: ext_clk: 15.0000.
designs/sky130hd/microwatt/rules-base.json updates:

Metric Old New Type
finish__timing__setup__ws -1.34 -2.71 Failing
finish__timing__setup__tns -157.0 -336.0 Failing

designs/sky130hs/ibex/rules-base.json updates:

Metric Old New Type
globalroute__timing__setup__tns -7.77 -33.7 Failing

Messages from CI

[INFO] asap7/minimal not included in CI.
[INFO] gf12 not included in the update.
[INFO] gf55 not included in the update.
[INFO] nangate45/bp_quad not included in CI.

povik and others added 10 commits March 11, 2026 17:46
Signed-off-by: Martin Povišer <povik@cutebit.org>
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
@dsengupta0628 dsengupta0628 added the UpdateRules Starts GHA to update rules label Mar 25, 2026
@openroad-ci openroad-ci removed the UpdateRules Starts GHA to update rules label Mar 25, 2026
@maliberty maliberty added the UpdateRules Starts GHA to update rules label Mar 25, 2026
@openroad-ci openroad-ci removed the UpdateRules Starts GHA to update rules label Mar 25, 2026
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
@dsengupta0628 dsengupta0628 added the UpdateRules Starts GHA to update rules label May 18, 2026
@openroad-ci openroad-ci removed the UpdateRules Starts GHA to update rules label May 18, 2026
@dsengupta0628
Copy link
Copy Markdown
Contributor

designs/asap7/swerv_wrapper/ actually shows [INFO] finish__timing__setup__tns pass test: -46693.1 >= -47000 so it is not as catastrophic

Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
@openroad-ci openroad-ci force-pushed the secure-fix_missing_para_dbmodnet branch from d6b6f0f to ba99381 Compare May 19, 2026 17:14
@dsengupta0628 dsengupta0628 added the UpdateRules Starts GHA to update rules label May 19, 2026
@openroad-ci openroad-ci removed the UpdateRules Starts GHA to update rules label May 19, 2026
},
"finish__timing__setup__tns": {
"value": -320.0,
"value": -47000.0,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why this number oscillates so much- yesterday baseline was -46993 and today it was somehow regoldened to -320 and my code makes it back to -47000. This is also the test that gets affected by my change- with correct para now, it fallsback to the PRIMA dcalc path and - without my isExternal fix, it would have crashed in PRIMA. So this testcase is really stress testing my change

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the -320 value comes from PR one month ago. In any case I would expect your change to degrade (i.e. fix the reporting on) designs with hierarchy enabled, which swerv_wrapper seems to be one of.

Copy link
Copy Markdown
Contributor

@dsengupta0628 dsengupta0628 May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird. yesterday I saw it -46993 in my local run.

"finish__timing__setup__ws": -239.109,
"finish__timing__setup__tns": -46693.1,

I wonder if this is exposing an issue in PRIMA delay calc now.. witherways, orthogonal..

Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
@maliberty
Copy link
Copy Markdown
Member

asap7/swerv_wrapper has a very large degradation. Do you understand why?

@openroad-ci openroad-ci force-pushed the secure-fix_missing_para_dbmodnet branch from d5b01c1 to 218ad1d Compare May 20, 2026 14:23
@dsengupta0628
Copy link
Copy Markdown
Contributor

asap7/swerv_wrapper has a very large degradation. Do you understand why?

Yes somewhat. Weird stuff going on in that design- but mainly wire caps are much larger so data path has higher delay. Slew at CLK pin Will discuss in mtng.

@dsengupta0628 dsengupta0628 added the UpdateRules Starts GHA to update rules label May 20, 2026
@openroad-ci openroad-ci removed the UpdateRules Starts GHA to update rules label May 20, 2026
@dsengupta0628 dsengupta0628 added the UpdateRules Starts GHA to update rules label May 20, 2026
@openroad-ci openroad-ci removed the UpdateRules Starts GHA to update rules label May 20, 2026
maliberty added 2 commits May 21, 2026 04:06
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
@maliberty maliberty added the UpdateRules Starts GHA to update rules label May 21, 2026
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@openroad-ci openroad-ci removed the UpdateRules Starts GHA to update rules label May 21, 2026
@maliberty maliberty merged commit bd2a6b6 into The-OpenROAD-Project:master May 21, 2026
8 checks passed
@maliberty maliberty deleted the secure-fix_missing_para_dbmodnet branch May 21, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants