fix(create): exclude demo files in lib, hooks, data, and components when demo / examples are disabled#430
fix(create): exclude demo files in lib, hooks, data, and components when demo / examples are disabled#430WaryaWayne wants to merge 1 commit intoTanStack:mainfrom
Conversation
…hen demo is disabled Previously only demo route files were filtered out when the user chose no demo files. Demo files in components/, lib/, hooks/, and data/ directories would still be created. Rename isDemoRoutePath to isDemoFilePath to reflect the broader scope and extend pattern matching to cover all non-route demo file paths.
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughA helper function for identifying demo-related files was renamed from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
unfinished. little clean up left. |
Previously only demo route files were filtered out when the user chose no demo files. Demo files in components/, lib/, hooks/, and data/ directories would still be created. Rename isDemoRoutePath to isDemoFilePath to reflect the broader scope and extend pattern matching to cover all non-route demo file paths.
Summary by CodeRabbit