test(helm): extend NodeSet tests for DRA-style claims and assertions#175
Open
giuliocalzo wants to merge 2 commits intoSlinkyProject:mainfrom
Open
test(helm): extend NodeSet tests for DRA-style claims and assertions#175giuliocalzo wants to merge 2 commits intoSlinkyProject:mainfrom
giuliocalzo wants to merge 2 commits intoSlinkyProject:mainfrom
Conversation
- Add pod template resourceClaims plus resources.claims coverage - Split plain pod template resources into a dedicated test - Assert full affinity block and topologySpreadConstraints via contains - Add blank lines between test cases for readability
giuliocalzo
requested review from
SkylerMalinowski,
alanmutsch,
catblade,
vivian-hafener and
wickberg
as code owners
vivian-hafener
requested review from
klairecodes
and removed request for
SkylerMalinowski,
alanmutsch,
catblade,
vivian-hafener and
wickberg
klairecodes
approved these changes
May 6, 2026
vivian-hafener
requested changes
May 6, 2026
Contributor
There was a problem hiding this comment.
I've requested changes in order to block the merge of this PR. We handle PR merges internally, instead of using GitHub, so we will handle the merge internally. Will close once merged internally per usual, just don't want to risk an accidental merge to main here as it is annoying to resolve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends
helm/slurm/tests/nodeset_test.yamlto cover Dynamic Resource Allocation-style pod configuration and to tighten a few assertions.Changes
podSpec.resourceClaims(asserted withcontains) andpodSpec.resources.claims(asserted withequalonspec.template.spec.resources).should set pod template resourceswithout mixing in claim fields.spec.template.spec.affinityobject instead of a single nested leaf path.containsonspec.template.spec.topologySpreadConstraintswith the full constraint object.Verification
helm unittest helm/slurm -f 'tests/nodeset_test.yaml'