Support placeholder on color settings#1224
Merged
Merged
Conversation
NathanPJF
force-pushed
the
color-placeholder-update
branch
from
07ac04c to
637115c
Compare
NathanPJF
changed the title
aswamy
reviewed
Jun 4, 2026
|
|
||
| export interface Color extends ColorBase<Type.Color> {} | ||
| export interface Color extends ColorBase<Type.Color> { | ||
| placeholder?: string; |
Contributor
There was a problem hiding this comment.
Could you also add the following prop please 🙏
alpha?: boolean;
Seems like this file has drifted
aswamy
approved these changes
Jun 4, 2026
Contributor
aswamy
left a comment
aswamy
left a comment
There was a problem hiding this comment.
Just make sure you run pnpm format to make CI pass before merging after the changes
| @@ -0,0 +1,6 @@ | |||
| --- | |||
| '@shopify/theme-check-common': patch | |||
| '@shopify/theme-language-server-common': patch | |||
Contributor
There was a problem hiding this comment.
I dont think you need this package in this changeset
Contributor
Author
There was a problem hiding this comment.
@aswamy you're right. I had an additional update in here, but I pulled that file out but didn't correct this line. Thanks!
NathanPJF
force-pushed
the
color-placeholder-update
branch
from
04eedc8 to
388cd60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
This PR wires up support for
placeholderoncolorsettings.Extending
Colorasplaceholderis not available to allColorBaseextensionsWhat's next? Any followup issues?
Related PR in theme-liquid-docs: Shopify/theme-liquid-docs#1709
Before you deploy
changeset