feat(weather): add error card and improve error handling

[nicomiguelino]

User description

Summary

• Add createErrorReporter that either throws (triggering panic-overlay when display_errors is enabled) or renders a custom error card in production
• Add glassmorphic error card styled to match the forecast card, with landscape and portrait support
• Throw on missing OpenWeatherMap API key instead of silently returning empty data
• Wrap initialization in try/catch/finally with a single signalReady() call
• Add no-api-key screenshot tests for 3840×2160 and 2160×3840
• Update unit test to expect a thrown error when the API key is absent

---

PR Type

Enhancement, Bug fix, Tests, Documentation

---

Description

• Adds configurable weather error handling

• Shows missing-key error card

• Tests no-key screenshots and throws

• Documents display_errors app setting

---

Diagram Walkthrough

flowchart LR
  settings["display_errors setting"]
  init["weather initialization"]
  api["OpenWeatherMap API key check"]
  reporter["error reporter"]
  overlay["panic overlay"]
  card["in-app error card"]
  settings -- "controls" --> reporter
  init -- "validates" --> api
  api -- "failure" --> reporter
  reporter -- "debug enabled" --> overlay
  reporter -- "debug disabled" --> card

Loading

File Walkthrough

	Relevant files
Tests	2 files screenshots.spec.ts Adds no-key screenshot coverage for error card                      +41/-0    weather.test.ts Updates missing API key unit expectation                                  +12/-10
Error handling	1 files main.ts Adds configurable initialization error reporting                  +49/-15
Bug fix	1 files weather.ts Throws when forecast API key missing                                          +8/-6
Enhancement	2 files style.css Styles responsive glassmorphic error screen                            +102/-0  index.html Adds hidden weather error screen markup                                    +16/-0
Documentation	1 files README.md Documents new `display_errors` setting                                      +1/-0
Configuration changes	2 files screenly.yml Adds `display_errors` manifest setting                                      +12/-1    screenly_qc.yml Adds QC `display_errors` manifest setting                                +12/-1
Additional files	12 files 1080x1920.webp [link]    1280x720.webp [link]    1920x1080.webp [link]    2160x3840.webp [link]    2160x4096.webp [link]    3840x2160.webp [link]    4096x2160.webp [link]    480x800.webp [link]    720x1280.webp [link]    800x480.webp [link]    no-api-key-2160x3840.webp [link]    no-api-key-3840x2160.webp [link]

---

[github-actions]

PR Reviewer Guide 🔍

(Review updated until commit 74b0611)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ No major issues detected

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Security	Honor error display setting The documented display_errors setting is inverted here: when it is false, detailed error messages are still shown on screen, and when it is true, the app throws instead of using the new error card. Make the setting control whether detailed text is displayed while still showing a safe error card to users. edge-apps/weather/src/main.ts [32-39] function createErrorReporter(displayErrors: boolean): ErrorReporter { - if (displayErrors) { - return (msg) => { - throw new Error(msg) - } + return (msg) => { + showError( + displayErrors + ? msg + : 'The weather data could not be loaded. Please check your configuration or contact your administrator.', + ) } - return showError } Suggestion importance[1-10]: 8 __ Why: The suggestion correctly identifies that display_errors=false still displays detailed error messages via showError, while display_errors=true throws instead of using the app's error UI. The proposed change better matches the documented setting and avoids exposing detailed errors by default.	Medium

[Copilot]

Pull request overview

Adds a display_errors setting to the Weather edge app and wires in the shared setupErrorHandling() hook so runtime failures can be surfaced via the panic-overlay mechanism (plus updates docs and screenshot-test mocks).

Changes:

• Added display_errors to screenly.yml and screenly_qc.yml (marked as optional + advanced).
• Invoked setupErrorHandling() during app startup in src/main.ts.
• Documented display_errors in the app README and included it in the e2e screenshot mock settings.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
edge-apps/weather/src/main.ts	Calls shared error-handling setup on DOM ready.
edge-apps/weather/screenly.yml	Adds display_errors manifest setting.
edge-apps/weather/screenly_qc.yml	Adds display_errors manifest setting for QC.
edge-apps/weather/README.md	Documents the new setting in the configuration table.
edge-apps/weather/e2e/screenshots.spec.ts	Ensures screenshot mocks include display_errors.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

Persistent review updated to latest commit 576e0ff

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Security	Honor error display setting The documented display_errors setting is inverted here: when it is false, detailed error messages are still shown on screen, and when it is true, the app throws instead of using the new error card. Make the setting control whether detailed text is displayed while still showing a safe error card to users. edge-apps/weather/src/main.ts [32-39] function createErrorReporter(displayErrors: boolean): ErrorReporter { - if (displayErrors) { - return (msg) => { - throw new Error(msg) - } + return (msg) => { + showError( + displayErrors + ? msg + : 'The weather data could not be loaded. Please check your configuration or contact your administrator.', + ) } - return showError } Suggestion importance[1-10]: 8 __ Why: The suggestion correctly identifies that display_errors=false still displays detailed error messages via showError, while display_errors=true throws instead of using the app's error UI. The proposed change better matches the documented setting and avoids exposing detailed errors by default.	Medium

[github-actions]

Persistent review updated to latest commit 74b0611

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Security	Honor error display setting The documented display_errors setting is inverted here: when it is false, detailed error messages are still shown on screen, and when it is true, the app throws instead of using the new error card. Make the setting control whether detailed text is displayed while still showing a safe error card to users. edge-apps/weather/src/main.ts [32-39] function createErrorReporter(displayErrors: boolean): ErrorReporter { - if (displayErrors) { - return (msg) => { - throw new Error(msg) - } + return (msg) => { + showError( + displayErrors + ? msg + : 'The weather data could not be loaded. Please check your configuration or contact your administrator.', + ) } - return showError } Suggestion importance[1-10]: 8 __ Why: The suggestion correctly identifies that display_errors=false still displays detailed error messages via showError, while display_errors=true throws instead of using the app's error UI. The proposed change better matches the documented setting and avoids exposing detailed errors by default.	Medium

[Copilot]

Pull request overview

Copilot reviewed 9 out of 21 changed files in this pull request and generated 5 comments.