Skip to content

fix left/right trigger being flipped on retroid#2797

Open
9cxndy wants to merge 1 commit into
ROCKNIX:nextfrom
9cxndy:next
Open

fix left/right trigger being flipped on retroid#2797
9cxndy wants to merge 1 commit into
ROCKNIX:nextfrom
9cxndy:next

Conversation

@9cxndy
Copy link
Copy Markdown

@9cxndy 9cxndy commented May 27, 2026

Summary

According to the kernel doc, left trigger should be ABS_HAT2Y not ABS_HAT2X.

Testing

  • How was this tested? (e.g. Built and tested on specific devices, manual testing steps, URLs for CI/CD build artifacts.)
  • Test results: (e.g. Screenshots, logs, performance metrics if applicable.)

Additional Context

  • Add any other information that might be helpful for the reviewer (e.g., performance implications, potential risks, specific areas to focus on.)

AI Usage

While ROCKNIX doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? NO

@loki666
Copy link
Copy Markdown
Contributor

loki666 commented May 27, 2026

already "corrected" by inputplumber profile,
do you have issues in games with triggers being flipped ?

@9cxndy
Copy link
Copy Markdown
Author

9cxndy commented May 27, 2026

but this kernel driver is objectively wrong... shouldn't require inputplumber to fix this when it can be fixed in the kernel.

@loki666
Copy link
Copy Markdown
Contributor

loki666 commented May 27, 2026

no issues then

@loki666 loki666 closed this May 27, 2026
@spycat88
Copy link
Copy Markdown
Contributor

spycat88 commented May 27, 2026

I agree with @9cxndy this should be corrected if its wrong, it can wait until after stable.

@spycat88 spycat88 reopened this May 27, 2026
@loki666
Copy link
Copy Markdown
Contributor

loki666 commented May 27, 2026

then at the very least, the inputplumber mapping need to also be fixed

Copy link
Copy Markdown
Contributor

@loki666 loki666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix inputplumber mapping accordingly

@loki666
Copy link
Copy Markdown
Contributor

loki666 commented May 27, 2026

and if we want be correct, we should even use ABS_Z/ABS_RZ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants