fix left/right trigger being flipped on retroid#2797
Open
9cxndy wants to merge 1 commit into
Open
Conversation
Contributor
|
already "corrected" by inputplumber profile, |
Author
|
but this kernel driver is objectively wrong... shouldn't require inputplumber to fix this when it can be fixed in the kernel. |
Contributor
|
no issues then |
Contributor
|
I agree with @9cxndy this should be corrected if its wrong, it can wait until after stable. |
Contributor
|
then at the very least, the inputplumber mapping need to also be fixed |
loki666
requested changes
May 27, 2026
Contributor
loki666
left a comment
There was a problem hiding this comment.
fix inputplumber mapping accordingly
Contributor
|
and if we want be correct, we should even use ABS_Z/ABS_RZ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
According to the kernel doc, left trigger should be
ABS_HAT2YnotABS_HAT2X.Testing
Additional Context
AI Usage
While ROCKNIX doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? NO