even more fixes and tests for mixed type AD#46
Merged
Conversation
lkdvos
reviewed
Jun 1, 2026
Member
lkdvos
left a comment
lkdvos
left a comment
There was a problem hiding this comment.
Do you think we should consider adding this function to the main package, and have dedicated overloads to avoid the intermediate allocation of the real vector? Or do we just leave this as is and revisit if this ever is important and someone complains? In any case I don't see that many uses of mixed precision AD that has to be hyper optimized so maybe this is overkill
Member
Author
|
I ran into this from PEPSKit of all places, I think it makes sense to keep it functional for now and if we find later it's a performance problem it's not hard to spend some time improving it. |
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
lkdvos
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.