Forward AD rules and tests for polar decompositions#242
Open
kshyatt wants to merge 6 commits into
Open
Conversation
Jutho
reviewed
Jun 3, 2026
Member
Author
|
🎉 CUDA tests are passing 🎉 |
Jutho
reviewed
Jun 3, 2026
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
lkdvos
reviewed
Jun 3, 2026
Member
lkdvos
left a comment
lkdvos
left a comment
There was a problem hiding this comment.
Left some suggestions about performance but otherwise looks great!!
Member
Author
I wrote this in a less performant way but clearer to me way at the start just to make sure it was correct, thanks for the suggestions! Think I got everything in both push-forwards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to just work out of the box without hacking at special tangents or anything, so why not add...