fix: Remove --with-deps from playwright install (was hanging)#2
Merged
Conversation
The action was hanging in `npx playwright install --with-deps chromium` for 8+ minutes until killed. The --with-deps flag invokes apt-get to install system packages, which on Ubuntu 24.04 GitHub runners hangs silently. Combined with `silent: true`, there was no visible output. Fix: - Drop --with-deps (Ubuntu 24.04 runners already have all required libs) - Pin @playwright/test to 1.49.0 (was using 'latest' which is risky) - Remove silent: true from npm install and playwright install so progress is visible if something does go wrong - Bump version to 1.2.1 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The QualityMax GitHub Action was hanging in
npx playwright install --with-deps chromiumfor 8+ minutes until killed. Fixed by removing the--with-depsflag (Ubuntu 24.04 runners already have all required system libs), pinning Playwright version, and removing silent flag so progress is visible.Root cause
From the GitHub Actions logs (run #24241246655):
The
--with-depsflag invokesapt-getto install system packages. On Ubuntu 24.04 GitHub runners this either hangs waiting for sudo or tries to install packages that are already present. Withsilent: trueon the exec call, there was no visible output to debug.Changes
--with-deps(Ubuntu 24.04 runners already have all required system libs)@playwright/testto1.49.0(was usinglatest)silent: truefrom npm install and playwright installTest plan
🤖 Generated with Claude Code