fix(simple-engine): SQL start timestamp multiplied by scrape_interval (#202)#330
Merged
Hidden character warning
The head ref may contain hidden characters: "202-calculate_start_timestamp_sql-multiplies-duration-by-scrape_interval-making-window-scrape_interval\u00d7-too-wide"
Conversation
…#202) get_duration() returns seconds, not a count of scrape intervals, so multiplying by prometheus_scrape_interval again produced a window scrape_interval× too wide. Drop the extra factor and rename the variable from scrape_intervals to duration_secs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
milindsrivastava1997
deleted the
202-calculate_start_timestamp_sql-multiplies-duration-by-scrape_interval-making-window-scrape_interval×-too-wide
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_duration() returns seconds, not a count of scrape intervals, so
multiplying by prometheus_scrape_interval again produced a window
scrape_interval× too wide. Drop the extra factor and rename the
variable from scrape_intervals to duration_secs.
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com