refactor: sketch-core retirement + branch-pin cleanup + elastic DSL test fix#309
Merged
milindsrivastava1997 merged 2 commits intomainfrom May 4, 2026
Merged
Conversation
zzylol
force-pushed
the
chore/track-asap-sketchlib-main
branch
from
a36f9d7 to
62831b7
Compare
zzylol
changed the title
zzylol
changed the title
After PR #307 was admin-merged with a failing test (and then reverted in PR #310), redo the consumer migration cleanly with two follow-up changes: 1. Drop the \`branch = "refactor/adopt-sketch-core-modules"\` pin from asap-query-engine/Cargo.toml. asap_sketchlib#36 is on main as commit \`d22a9ab\`; the consumer now tracks the default branch. 2. Loosen the \`test_esdsl_time_range_query\` assertion to ±1 tolerance. The test computed P90 of 200..300 from a KLL and asserted exactly 291; asap_sketchlib's KLL reports 290 on this distribution, which is within KLL's published rank-error bound but breaks an exact-match assertion that previously passed against the dsrs/datasketches backend (now retired with sketch-core). Tests: - \`cargo test -p query_engine_rust --lib precompute_operators\` → 87 / 0 - \`cargo test -p query_engine_rust --lib tests::elastic\` → 15 / 0 - \`cargo test -p query_engine_rust --lib tests::elastic_dsl_query_tests::tests::test_esdsl_time_range_query\` → passes Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
zzylol
force-pushed
the
chore/track-asap-sketchlib-main
branch
from
62831b7 to
fc85a83
Compare
milindsrivastava1997
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #307 (sketch-core retirement / consumer migration to `asap_sketchlib::sketches::*`) was admin-merged with a failing test. PR #310 reverted it. This PR redoes #307's content cleanly, plus the #309 cleanup (drop branch pin) and a fix for the test that was broken on #307.
Changes
Re-apply refactor: retire sketch-core mirror #307's content — switch consumer imports from `sketch_core` to `asap_sketchlib::sketches::*`, delete the `asap-common/sketch-core` workspace member, drop the legacy fork's `sketchlib_fidelity` bin and `test_both_backends` test.
Drop the `branch = "refactor/adopt-sketch-core-modules"` pin from `asap-query-engine/Cargo.toml`. asap_sketchlib#36 is now on main as commit `d22a9ab`; consumer tracks the default branch.
Fix `test_esdsl_time_range_query` (the test that broke refactor: retire sketch-core mirror #307's CI). It computed P90 of `200..300` from a KLL and asserted exactly `291.0`. asap_sketchlib's KLL reports `290.0` on this distribution — within KLL's published rank-error bound, but breaks an exact-match assertion that previously passed against the dsrs/datasketches backend (now retired). Loosened to `±1` tolerance.
Tests
```
cargo test -p query_engine_rust --lib precompute_operators → 87 passed, 0 failed
cargo test -p query_engine_rust --lib tests::elastic → 15 passed, 0 failed
cargo test -p query_engine_rust --lib tests::elastic_dsl_query_tests::tests::test_esdsl_time_range_query → 1 passed, 0 failed
```
Replaces