Add gen-idea skill to Codex installs#101
Conversation
There was a problem hiding this comment.
Pull request overview
This PR exposes the existing gen-idea workflow to Codex/Kimi installs by adding a new humanize-gen-idea entrypoint skill, updating the unified installer + install docs, and adding regression coverage to ensure the wiring stays intact.
Changes:
- Add
skills/humanize-gen-ideaflow skill and include it in the unified installer’sSKILL_NAMES. - Update Codex/Kimi/Claude install docs to mention the new skill/command.
- Add wiring + install regression tests and include them in the test runner.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
skills/humanize-gen-idea/SKILL.md |
New flow skill that documents the required gen-idea execution sequence for Codex/Kimi entrypoints. |
scripts/install-skill.sh |
Adds humanize-gen-idea to the install set and generalizes installed-layout detection to iterate SKILL_NAMES. |
docs/install-for-codex.md |
Documents that Codex installs now include the humanize-gen-idea skill directory. |
docs/install-for-kimi.md |
Documents that Kimi installs now include the humanize-gen-idea skill and updates manual install steps accordingly. |
docs/install-for-claude.md |
Adds /humanize:gen-idea to the list of post-install commands. |
tests/test-gen-idea-wiring.sh |
New test to assert skill + installer + docs wiring for gen-idea. |
tests/test-codex-hook-install.sh |
Extends Codex install regression to assert humanize-gen-idea is installed. |
tests/run-all-tests.sh |
Adds the new wiring test to the test suite list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Strip user-invocable flag from SKILL.md files for runtime visibility | ||
| # (This matches the behavior of scripts/install-skill.sh) | ||
| for skill in humanize humanize-gen-plan humanize-refine-plan humanize-rlcr; do | ||
| for skill in humanize humanize-gen-idea humanize-gen-plan humanize-refine-plan humanize-rlcr; do | ||
| awk ' |
There was a problem hiding this comment.
The manual install instructions say this awk step “matches the behavior of scripts/install-skill.sh”, but it only strips user-invocable. The installer’s strip_claude_specific_frontmatter() also removes disable-model-invocation and hide-from-slash-command-tool, so manual installs will produce different SKILL.md frontmatter. Update this snippet to strip the same keys (or adjust the comment to reflect the actual behavior).
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9671b42681
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for skill in "${SKILL_NAMES[@]}"; do | ||
| if [[ ! -f "$skills_root/$skill/SKILL.md" ]]; then | ||
| all_skills_present="false" |
There was a problem hiding this comment.
In resolve_source_layout, the installed-runtime branch now requires every entry in SKILL_NAMES to already exist under skills_root before it accepts the layout. That makes upgrades from pre-humanize-gen-idea installs fail early: running the installer from <skills-dir>/humanize/scripts/install-skill.sh on an older installation exits with could not resolve Humanize source layout instead of syncing the new skill. This is a regression in the script’s in-place upgrade path; the runtime-layout detection should tolerate older skill sets and let the normal sync step add missing entrypoints.
Useful? React with 👍 / 👎.
|
@shinezyy can you take a look? |
Summary
humanize-gen-ideaskill so Codex and Kimi installs expose the existing gen-idea workflowTest Plan
bash tests/test-gen-idea-wiring.shbash tests/test-codex-hook-install.sh