feat(perf_hooks): observe({ buffered: true }) delivers pre-existing entries (#1390)#1441
Merged
Merged
Conversation
…ntries (#1390) PerformanceObserver.observe({ type, buffered: true }) now queues the timeline entries that already match the observed type(s) and arms the async flush, so the callback fires on a later turn with entries created before observe() was called — matching Node. Non-buffered observe is unchanged. Flips node-suite/perf_hooks/observer/buffered to PASS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PerformanceObserver.observe({ type, buffered: true })should deliver entries created beforeobserve()was called (node:perf_hooks gap #1390, umbrella #793). Perry never delivered them — the callback didn't fire.js_perf_observer_observenow parses thebufferedflag; when set, it copies the timeline entries matching the observed type(s) into the observer's pending buffer and arms the async flush, so the callback fires on a later turn with the pre-existing entries. Non-bufferedobserve()is unchanged.Test
Flips
test-parity/node-suite/perf_hooks/observer/bufferedto PASS (buffered count: 2); all other observer tests (observe-marks/measures, multiple-observers, take-records, …) still pass.Closes #1390.