Fix some gems being hidden from gem list#9796
Merged
LocalIdentity merged 1 commit intodevfrom Apr 20, 2026
Merged
Conversation
Using `fromItem` isn't going to work as the gem list gets mutated with it from many other places and it's too risky to change those Instead we now use a different tag that is untouched by anything else so it wont fail Tried looking in the game files to see if there was anything that'd show if the gems couldn't drop anymore and could not find anything so have to keep it hardcoded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9795
Description of the problem being solved:
Using
fromItemisn't going to work as the gem list gets mutated with it from many other places and it's too risky to change thoseInstead we now use a different tag that is untouched by anything else so it wont fail
Tried looking in the game files to see if there was anything that'd show if the gems couldn't drop anymore and could not find anything so have to keep it hardcoded: