Fix: [CI] Use unprivileged env to build website#386
Merged
glx22 merged 1 commit intoOpenTTD:mainfrom Apr 21, 2026
Merged
Conversation
PeterN
approved these changes
Apr 21, 2026
Member
PeterN
left a comment
PeterN
left a comment
There was a problem hiding this comment.
I don't really know any better :/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is some nastiness going around on GitHub, where people create a PR which tries to exfil repo secrets. And
publish.ymlis potentially vulnerable because it's usingpull_request_target.Split build and publish, so build workflow is always done in an unprivileged env.
Build result is then uploaded as artifacts and publish workflow (using
workflow_run) can retrieve it to do the actual upload to cloudflare.Also migrated from
cloudflare/pages-action(deprecated) tocloudflare/wrangler-action.BTW cloudflare step is totally untested because I can't do it on my fork, but I tested all the steps before this one.
Of course the new
publish.ymlcan't run before the PR is merged as it needs to be in default branch. And when it runs (tested on my fork) it is not reported in the PR checks.