Skip to content

feat: Grouping the traffic lights#902

Open
plass-bertrandt wants to merge 1 commit into
OpenSimulationInterface:masterfrom
plass-bertrandt:feature/mp/trafficlight-group
Open

feat: Grouping the traffic lights#902
plass-bertrandt wants to merge 1 commit into
OpenSimulationInterface:masterfrom
plass-bertrandt:feature/mp/trafficlight-group

Conversation

@plass-bertrandt
Copy link
Copy Markdown

Reference to a related issue in the repository

TrafficLight rework proposal. #754

Add a description

The individual bulbs of a traffic light rarely function as standalone signals. Rather, they form a unit consisting of two or three bulbs that convey a specific instruction to the driver.

The introduction of the group_id defines a unique assignment of the lights. It replaces heuristics—such as those based on position and orientation—that were previously necessary in the user software.

Some questions to ask:

  • It's a new feature.
  • Backward compatibility:
    IF group_id IS PRESENT:
        → Group bulbs by group_id
    ELSE:
        → Fall back to position-based / heuristic grouping (legacy)
    

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

If you can’t check all of them, please explain why.
If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!

The individual bulbs of a traffic light rarely function as standalone signals. Rather, they form a unit consisting of two or three bulbs that convey a specific instruction to the driver.

The introduction of the group_id defines a unique assignment of the lights. It replaces heuristics—such as those based on position and orientation—that were previously necessary in the user software.

Signed-off-by: Michael Plass <Michael.Plass@partner.bmw.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant