feat: Grouping the traffic lights#902
Open
plass-bertrandt wants to merge 1 commit into
Open
Conversation
The individual bulbs of a traffic light rarely function as standalone signals. Rather, they form a unit consisting of two or three bulbs that convey a specific instruction to the driver. The introduction of the group_id defines a unique assignment of the lights. It replaces heuristics—such as those based on position and orientation—that were previously necessary in the user software. Signed-off-by: Michael Plass <Michael.Plass@partner.bmw.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference to a related issue in the repository
TrafficLight rework proposal. #754
Add a description
The individual bulbs of a traffic light rarely function as standalone signals. Rather, they form a unit consisting of two or three bulbs that convey a specific instruction to the driver.
The introduction of the group_id defines a unique assignment of the lights. It replaces heuristics—such as those based on position and orientation—that were previously necessary in the user software.
Some questions to ask:
Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:
If you can’t check all of them, please explain why.
If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!