refactor: simplify preview handling and remove unnecessary memoization#488
Open
refactor: simplify preview handling and remove unnecessary memoization#488
Conversation
Member
Author
|
播放压缩包内的视频时，下一个视频会跳转到压缩包外，想着一起改了，改的地方有点多，下次吧 |
j2rong4cn
commented
Apr 29, 2026
| return getPreviews({ ...objStore.obj, provider: objStore.provider }) | ||
| }) | ||
| const selectedPreviewKey = createMemo(() => searchParams["preview"] || "") | ||
| const previews = getPreviews({ ...objStore.obj, provider: objStore.provider }) |
Member
Author
There was a problem hiding this comment.
如果使用createMemo在预览压缩包时更新objStore.obj这里也会更新，导致回到压缩包根目录
Co-authored-by: Copilot <copilot@github.com>
j2rong4cn
force-pushed
the
refactor-preview
branch
from
93e08f4 to
cf503e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description / 描述
移除非必要的createMemo，因为预览文件会重载File组件
OpenList-Frontend/src/pages/home/Obj.tsx
Lines 141 to 144 in 2e0acf9
修复无法下载加密压缩包内的文件，由 #329 引入
Motivation and Context / 背景
Close #487
#446 (comment)
How Has This Been Tested? / 测试
Checklist / 检查清单
我已阅读 CONTRIBUTING 文档。
go fmtor prettier.我已使用
go fmt或 prettier 格式化提交的代码。我已为此 PR 添加了适当的标签（如无权限或需要的标签不存在，请在描述中说明，管理员将后续处理）。
我已在适当情况下使用"Request review"功能请求相关代码作者进行审查。
我已相应更新了相关仓库（若适用）。