Open
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
|
atravitz
force-pushed
the
update_abfe_data
branch
from
f28acc8 to
2d4314f
Compare
atravitz
commented
Apr 24, 2026
| @@ -33,32 +33,24 @@ | |||
| "name": "stdout", | |||
Contributor
Author
There was a problem hiding this comment.
Line #1. !curl -O https://zenodo.org/records/19498687/files/abfe_results.zip
this will overwrite old data instead of hanging and waiting for user input - I was having trouble reproducing the CI error because the stale data was still in my repo.
Reply via ReviewNB
atravitz
commented
Apr 24, 2026
| @@ -33,32 +33,24 @@ | |||
| "name": "stdout", | |||
Contributor
Author
There was a problem hiding this comment.
we don't need to include this additional handling if we don't want to, but this allows users to get to parity with the CLI.
Reply via ReviewNB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this updates the notebook to pull the new format of results data with multiple units and carry over some of the changes from openfe's gather to handle the changes.
We expect the CI to still fail on the septop analysis notebook.