fix: resolve GBK encoding errors on Windows for Chinese content#610
Open
Mars-ending wants to merge 1 commit intoOpenBMB:mainfrom
Open
fix: resolve GBK encoding errors on Windows for Chinese content#610Mars-ending wants to merge 1 commit intoOpenBMB:mainfrom
Mars-ending wants to merge 1 commit intoOpenBMB:mainfrom
Conversation
## Problem On Windows systems with Chinese locale, Python's stdout uses GBK encoding by default. This causes UnicodeEncodeError when: 1. Model responses contain CJK characters or emoji 2. Logs are written to files via FileHandler without encoding specified Error example: 'gbk' codec can't encode character '\U0001f4d6' in position 1189 ## Changes 1. server_main.py: - Wrap sys.stdout/stderr with UTF-8 TextIOWrapper on Windows - Add encoding='utf-8' to FileHandler for server.log 2. utils/structured_logger.py: - Add encoding='utf-8' to FileHandler for workflow logs 3. utils/logger.py: - Wrap print() in try/except for UnicodeEncodeError fallback - On encoding error, strip problematic characters gracefully ## Testing Verified on Windows 11 with Chinese locale: - Workflow with Chinese task prompts now completes without encoding errors - Generated files correctly contain Unicode characters (CJK, emoji) --- Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows systems with Chinese locale, Python's stdout uses GBK encoding by default. This causes UnicodeEncodeError when:
Error example:
'gbk' codec can't encode character '\U0001f4d6' in position 1189
Changes
server_main.py:
utils/structured_logger.py:
utils/logger.py:
Testing
Verified on Windows 11 with Chinese locale: