Skip to content

fix(asr): stabilize MiMo HTTP tests on macOS#608

Merged
H-Chris233 merged 1 commit into
Open-Less:betafrom
H-Chris233:fix/issue-600-macos-ci
Jun 6, 2026
Merged

fix(asr): stabilize MiMo HTTP tests on macOS#608
H-Chris233 merged 1 commit into
Open-Less:betafrom
H-Chris233:fix/issue-600-macos-ci

Conversation

@H-Chris233
Copy link
Copy Markdown
Collaborator

@H-Chris233 H-Chris233 commented Jun 6, 2026

User description

Summary

  • Fix the post-merge macOS CI failure in MiMo ASR tests.
  • Explicitly switch accepted TCP streams back to blocking mode in the local HTTP test server.
  • Keeps the nonblocking listener polling, but makes request-body reads deterministic across macOS/Linux.

Root Cause

The failing beta push run was 27059512049, job macOS checks, step Run Rust backend unit tests.
mimo_splits_audio_before_base64_limit panicked on macOS with WouldBlock while reading the large local HTTP request body because the accepted TcpStream behaved as nonblocking. The client then saw Connection reset by peer.

Test Plan

  • cargo test --manifest-path "openless-all/app/src-tauri/Cargo.toml" mimo_splits_audio_before_base64_limit -- --test-threads=1
  • cargo test --manifest-path "openless-all/app/src-tauri/Cargo.toml" --lib
  • git diff --check
  • git diff --cached --check

Follow-up to #607 / Refs #600


PR Type

Bug fix


Description

  • Fix MiMo ASR test failure on macOS by setting accepted TCP streams to blocking mode

File Walkthrough

Relevant files
Bug fix
mimo.rs
Add blocking mode to test HTTP streams                                     

openless-all/app/src-tauri/src/asr/mimo.rs

  • Added stream.set_nonblocking(false) to two test helper functions after
    accepting connections
  • Prevents WouldBlock error on macOS when reading request body from
    nonblocking streams
+2/-0     

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 6, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ❌

600 - Not compliant

Non-compliant requirements:

  • Add Xiaomi MiMo ASR provider

607 - Partially compliant

Compliant requirements:

  • Ensure tests pass on all platforms (test plan includes cargo test)

Non-compliant requirements:

  • Add Xiaomi MiMo ASR as a cloud ASR provider using /chat/completions + input_audio protocol
  • Implement batch ASR client with 180s chunking and joining
  • Add settings, overview, i18n entries and provider validation/model-list handling
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ No major issues detected

@H-Chris233 H-Chris233 merged commit 9f8f8d2 into Open-Less:beta Jun 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant