fix(asr): stabilize MiMo HTTP tests on macOS#608
Merged
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
Root Cause
The failing
betapush run was27059512049, jobmacOS checks, stepRun Rust backend unit tests.mimo_splits_audio_before_base64_limitpanicked on macOS withWouldBlockwhile reading the large local HTTP request body because the acceptedTcpStreambehaved as nonblocking. The client then sawConnection reset by peer.Test Plan
cargo test --manifest-path "openless-all/app/src-tauri/Cargo.toml" mimo_splits_audio_before_base64_limit -- --test-threads=1cargo test --manifest-path "openless-all/app/src-tauri/Cargo.toml" --libgit diff --checkgit diff --cached --checkFollow-up to #607 / Refs #600
PR Type
Bug fix
Description
File Walkthrough
mimo.rs
Add blocking mode to test HTTP streamsopenless-all/app/src-tauri/src/asr/mimo.rs
stream.set_nonblocking(false)to two test helper functions afteraccepting connections
WouldBlockerror on macOS when reading request body fromnonblocking streams