Enhance FHIR resolution capabilities and response structure#20
Merged
Conversation
- Updated `FhirResolution` to include `value_as_concept`, `value_target_field`, `concept_map_id`, and `mapping_note` for improved handling of composite concepts and administrative code resolutions. - Modified `resolve()`, `resolve_batch()`, and `resolve_codeable_concept()` methods to accept an `on_unmapped` argument, allowing for flexible handling of unmapped codes. - Ensured `user_selected` is correctly passed through from FHIR inputs, enhancing the resolution process. - Updated documentation and tests to reflect these changes and ensure compatibility.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found across 4 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
- Enhanced `resolve_batch()` and `resolve_codeable_concept()` methods to include the `on_unmapped` parameter, allowing for better handling of unmapped codes. - Added unit tests to verify that the `on_unmapped` parameter is correctly forwarded in the request body for both synchronous and asynchronous calls. - Updated existing tests to ensure comprehensive coverage of the new functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Enhances FHIR resolution with typed value-as-concept fields, configurable unmapped-code handling, and support for user-selected codings. Improves CodeableConcept selection and keeps ETL writes stable when inputs don’t map.
FhirResolutionnow includesvalue_as_concept,value_target_field,concept_map_id, andmapping_note.resolve(),resolve_batch(), andresolve_codeable_concept()(sync and async) accept and forwardon_unmapped("error"default;"sentinel"returns aconcept_id0 record).user_selected; FHIRuserSelectedis mapped to it, and a user-selected coding takes precedence in CodeableConcept resolution.Written for commit 4e020bb. Summary will update on new commits. Review in cubic