Skip to content

[19.0][MIG] queue_job_batch: Migration to 19.0#920

Open
YoussefEgla wants to merge 3 commits intoOCA:19.0from
YoussefEgla:19.0-mig-queue_job_batch-jb-web
Open

[19.0][MIG] queue_job_batch: Migration to 19.0#920
YoussefEgla wants to merge 3 commits intoOCA:19.0from
YoussefEgla:19.0-mig-queue_job_batch-jb-web

Conversation

@YoussefEgla
Copy link
Copy Markdown

@YoussefEgla YoussefEgla commented Apr 17, 2026

Port queue_job_batch to 19.0 and enable it in the repository.

What is included

  • enable queue_job_batch again in 19.0 and remove it from the non-installable addon exclusions
  • update the manifest and generated addon documentation for 19.0
  • migrate the webclient/store integration to the 19.0 mail store API
  • keep queue.job.create private while still attaching newly created jobs to a batch through the job_batch context
  • update the systray store bootstrap so unread batch counters are loaded through store.add_global_values(...)
  • update the systray menu component to use the current store service API
  • adapt security setup from category_id to privilege_id
  • restore the batch README example with minimal 19.0 adjustments
  • add regression tests for:
    • store bootstrap values for batch users
    • the private protection on queue.job.create
    • creation of batched test jobs through the new controller helper
  • fix the search view so the module installs on 19.0 by removing unsupported attributes from the search-view group node
  • add /queue_job/create_test_batch, a controller route restricted to ERP managers that creates a batch and enqueues built-in queue test jobs into it for validation

Main technical changes

  • controllers/webclient.py
    • migrate _process_request_for_internal_user to the 19.0 signature
    • push batch counter values with store.add_global_values(...)
  • models/res_users.py
    • populate unread batch flags and counters with the 19.0 mail store bootstrap flow
  • models/queue_job.py
    • mark create() as @api.private
    • keep linking created jobs to job_batch_id
  • security/security.xml
    • use privilege_id for the batch user group
  • static/src/Store.esm.js
    • drop the obsolete initMessagingParams override
  • static/src/components/QueueJobBatchMenu.esm.js
    • switch to useService("mail.store")
    • load batch data with fetchStoreData("systray_get_queue_job_batches")
  • views/queue_job_batch_views.xml
    • remove unsupported search-view group attributes so the module installs cleanly on 19.0
  • controllers/main.py
    • add a batch-aware test endpoint and helper for manual validation
  • tests/test_queue_job_batch.py
    • add coverage for the batch test helper in addition to the migration regression checks

Validation

  • local editor diagnostics on the changed Python, JS, and XML files showed no errors
  • manual validation was performed by creating a test batch through the new route and confirming the jobs reached done and the batch reached finished

@YoussefEgla YoussefEgla changed the title [MIG] queue_job_batch: Migration to 19.0 [19.0][MIG] queue_job_batch: Migration to 19.0 Apr 17, 2026
@OCA-git-bot OCA-git-bot added mod:base_import_async Module base_import_async and removed mod:base_import_async Module base_import_async labels Apr 17, 2026
@YoussefEgla YoussefEgla force-pushed the 19.0-mig-queue_job_batch-jb-web branch from e435b4a to e1bf0b2 Compare April 17, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants