Skip to content

Decode bytes to string in CSV writer #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
whynotkimhari wants to merge 2 commits into
base: 16.0
Choose a base branch
from
+6 −1
Open

Decode bytes to string in CSV writer #917

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4b29ce
Decode bytes to string in CSV writer
whynotkimhari Apr 15, 2026
708e469
Update cell decoding to handle bytearray and utf-8
whynotkimhari Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion base_import_async/models/base_import_import.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,12 @@ def _create_csv_attachment(self, fields, data, options, file_name):
encoding = options.get(OPT_ENCODING) or "utf-8"
writer.writerow(fields)
for row in data:
writer.writerow(row)
cleaned_row = []
for cell in row:
if isinstance(cell, (bytes, bytearray)):
cell = cell.decode("utf-8")
cleaned_row.append(cell)
writer.writerow(cleaned_row)
# create attachment. Remove default values from context
context = self.env.context
context_copy = {}
Expand Down
Loading