Descoping CR Feature by wavehassman · Pull Request #4206 · Northeastern-Electric-Racing/FinishLine

wavehassman · 2026-05-13T21:22:36Z

Changes

Removes all legacy CR UI elements and updates the CR detail page as part of the broader CR descoping epic. Specifically:

Removed "Request Change" option from project and work package dropdown menus: "Edit" is now the only entry point
Make these one button: "Submit and Implement" for auto-implementing changes (leadership), "Create Change Request" for changes requiring manual approval
New project creation now directly implements without requiring a change request: "Change Request" button hidden and "Create Project" button always enabled
Reviewer selection made optional on CR submission: removed browser-level HTML required attribute from the reviewer autocomplete
Updated CR detail page to display the new why field directly, removing references to deleted scopeChangeRequest, proposedSolutions, and wbsProposedChanges fields
Fixed backend car filter queries (getAllChangeRequests, getToReviewChangeRequests, getUnreviewedChangeRequests, getApprovedChangeRequests) to include CRs linked to CAR-level WBS elements, so new project proposal CRs show up correctly in all CR list views
Updated E2E tests to reflect the new simplified CR form, removing assertions on deleted fields (ISSUE/DEFINITION_CHANGE/OTHER types, "What needs to be changed") and adding a test verifying CR submission works without a reviewer
Removed Create Change Request button from Change Request page

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

Closes #4157

…ality

…ma-changes #4168 schema changes

…oval-logic #4170 Update Approval Logic

…slack-notif-diff-on-cr-submit

#4173 simplified making a CR

…k-notif-diff-on-cr-submit #4171 Slack Notification with Diff

…e-gate-input #4176 added dateCompleted to stage gate

…n making a new project

…ve-old-cr-stuff #4174 frontend changes

…lack-button #4172 started cr approve slack button

chpy04

Functionality notes:

When I change the lead and then change another part of a project (such as the name or description or budget), it gives this error: (this does not appear to be an issue on work packages)
Changing only the budget on a project makes a standard change request not a budget change request (I believe this was already a bug). This also feeds into functionality that I don't think we don't have right now: we should make multiple change requests if different kinds are required. For example, if I change the leadership, budget, and description, there should be a leadership CR, a standard CR, and a budget CR. On a completely seperate not I don't think we shoul dactually need CRs for changing project information other than budget, but thats another thing. If we want to say this bullet is out of scope for this branch thats fine but should definately go in the fall CR epic
When I have the modal to submit a CR and click the dropdown to select a reviewer it is cut off by the modal and I have to scroll
After I submit a CR it takes me back to the CR page. it should take me to the change requests page
implement and create change request buttons are not merged into one but they should be
Allow any head or admin plus requested reviewer to review on slack

…erge two buttons

chpy04 · 2026-06-05T00:23:24Z

+
+    try {
+      // Action-specific validation: verify action_id
+      if (firstAction.action_id !== 'approve_cr') {


I'm pretty sure this is unreachable code? If its not Im confused when this would happen and we should have a more specific error message / guard. If anything we should not be calling the controller if this was the case

chpy04 · 2026-06-05T00:25:51Z

+
+      // Action-specific validation: verify value format
+      let actionValue: CrApprovalActionValue;
+      try {


really not a fan of nested try catches

chpy04 · 2026-06-05T00:26:52Z

+  Prisma.validator<Prisma.Project_Proposed_ChangesDefaultArgs>()({
+    include: {
+      teams: getTeamQueryArgs(organizationId),
+      car: { include: { wbsElement: true } },


chpy04 · 2026-06-05T00:27:05Z

+  Prisma.validator<Prisma.Work_Package_Proposed_ChangesDefaultArgs>()({
+    include: {
+      wbsProposedChanges: {
+        include: {


chpy04 · 2026-06-05T00:27:10Z

+    include: {
+      wbsProposedChanges: {
+        include: {
+          links: { where: { dateDeleted: null }, include: { linkType: true } },


chpy04 · 2026-06-05T00:29:31Z

+SET 
+  why = CONCAT(
+    'Type: ', cr.type::text,
+    CASE WHEN sc.what IS NOT NULL THEN CONCAT(' | What: ', sc.what) ELSE '' END,


can we use newlines instead of pipes? the pipes are kind of hard to interpret retrospectively

chpy04 · 2026-06-05T19:03:38Z

+
+  const addDiff = (label: string, before: string | number | null | undefined, after: string | number | null | undefined) => {
+    const b = String(before ?? '(none)');
+    const a = String(after ?? '(none)');


nit: if before or after could be a number, they could be 0, so lets guard against that getting changed to '(none)'

chpy04 · 2026-06-05T19:15:24Z

+): string => {
+  if (!proposed) return '';
+
+  const isWpChange = 'startDate' in proposed;


This is a very fragile way to determine which type we are working with. In this case an isntanceof actually makes a lot more sense. In addittion, you can actuall get kind of fance with the types and do something like:

const isWpChange(cr: ProjectProposedChangesCreateArgs | WorkPackageProposedChangesCreateArgs | undefined): cr is WorkPackageProposedChangesCreateArgs { return cr instanceof WorkPackageProposedChangesCreateArgs }

and vise versa with the project. The cr is <type> means that if the predicate passes in an if guard (like below), you the type checker will automatically narrow into that specific type and you don't need to cast

chpy04 · 2026-06-05T19:15:43Z


-    await Promise.all(changePromises);
+  if (isWpChange) {
+    const wpProposed = proposed as WorkPackageProposedChangesCreateArgs;


wouldn't be needed if you use the above syntax

chpy04 · 2026-06-05T19:17:08Z

+      addNew('Manager', wpProposed.managerId);
+      addNew('Start date', wpProposed.startDate);
+      addNew('Duration', wpProposed.duration);
+      addNew('Stage', wpProposed.stage);


I feel like we should be able to collablse the addNew and addDiff into a single function that just knows an empty value means you are adding a new, but if I'm missing something this is fine to leave as is

wavehassman and others added 30 commits April 21, 2026 17:03

#4168 2 migrations + changes everywhere to get rid of unused function…

7102b74

…ality

feature branch

7b5107c

#4168 combined migration files

9a181dc

#4168 requested changes

a153a55

Merge pull request #4181 from Northeastern-Electric-Racing/#4168-sche…

67a5de3

…ma-changes #4168 schema changes

#4170 updated service and added test

9f82982

#4170 allow heads and above to review their own crs

567df82

Merge pull request #4185 from Northeastern-Electric-Racing/#4170-appr…

2b715d2

…oval-logic #4170 Update Approval Logic

#4171 diff calc and added why + changes to notif

44fc98b

#4171 added project link diffs

e42d414

#4173 made reviewer a user, fixed up change request form

e96d215

#4174 removed old cr stuff and fixed up all the frontend

3265598

#4174 added check on reviewer id and added bullets to diff

93ea2b7

#4174 fix tests

9ea9b59

#4176 added dateCompleted to stage gate

838f8bf

#4176 cant mark an end date before the start date

cc998cd

#4176 put error above loading

db4e3b4

Merge remote-tracking branch 'origin/feature/descoping-cr' into #4171-…

a04aa33

…slack-notif-diff-on-cr-submit

#4171 add wp deliverables to diff

d5cdc6f

Merge pull request #4192 from Northeastern-Electric-Racing/#4173-cr-form

9db010b

#4173 simplified making a CR

#4174 added toast, fixed button formatting

9c7ff1a

#4176 removed newDuration

2d76eb1

Merge pull request #4190 from Northeastern-Electric-Racing/#4171-slac…

e6b2661

…k-notif-diff-on-cr-submit #4171 Slack Notification with Diff

Merge pull request #4194 from Northeastern-Electric-Racing/#4176-stag…

eb6fbc8

…e-gate-input #4176 added dateCompleted to stage gate

#4174 merge conflicts

83d971e

#4174 made reviewer optional, do not need to make a change rquest whe…

4f316f7

…n making a new project

#4172 started cr approve slack button

f94c8d7

Merge pull request #4193 from Northeastern-Electric-Racing/#4174-remo…

c577506

…ve-old-cr-stuff #4174 frontend changes

#4172 fix lint

ba4baaa

#4172 fix build issue

0b3225a

staysgt and others added 10 commits May 12, 2026 09:41

#4172 fix build

94e7fe2

#4172 fix build hopefully

0ad7c39

Merge branch 'feature/descoping-cr' into #4172-cr-slack-button

cc8ad81

#4172 merged in new changes

19d4058

#4172 fix from review

de2130e

Merge pull request #4202 from Northeastern-Electric-Racing/#4172-cr-s…

776c52f

…lack-button #4172 started cr approve slack button

merge into develop

3b8d9d9

Merge branch 'develop' into feature/descoping-cr

b0b5ee8

fix: update e2e tests for descoped CR workflow

e54a70f

hopefully works now

8d3c591

wavehassman requested a review from chpy04 May 13, 2026 22:49

wavehassman assigned wavehassman and staysgt May 13, 2026

chpy04 requested changes May 14, 2026

View reviewed changes

wavehassman added 2 commits May 15, 2026 15:26

make multiple CRs with every change, remove crId from edit project, m…

92dba94

…erge two buttons

linting and system tests

2d951da

wavehassman requested a review from chpy04 May 15, 2026 19:35

wavehassman added 2 commits May 15, 2026 15:40

linting round 2

14cb716

prettier

cb121ce

chpy04 requested changes Jun 5, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Descoping CR Feature#4206

Descoping CR Feature#4206
wavehassman wants to merge 44 commits into
developfrom
feature/descoping-cr

wavehassman commented May 13, 2026 •

edited

Loading

Uh oh!

chpy04 left a comment •

edited by wavehassman

Loading

Uh oh!

chpy04 Jun 5, 2026

Uh oh!

chpy04 Jun 5, 2026

Uh oh!

chpy04 Jun 5, 2026

Uh oh!

chpy04 Jun 5, 2026

Uh oh!

chpy04 Jun 5, 2026

Uh oh!

chpy04 Jun 5, 2026

Uh oh!

chpy04 Jun 5, 2026

Uh oh!

chpy04 Jun 5, 2026

Uh oh!

chpy04 Jun 5, 2026

Uh oh!

chpy04 Jun 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

wavehassman commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Checklist

Uh oh!

chpy04 left a comment • edited by wavehassman Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wavehassman commented May 13, 2026 •

edited

Loading

chpy04 left a comment •

edited by wavehassman

Loading