Improve simultaneous choices and autocomplete handling

[KubaZ2]

Fixes #341

[github-actions]

The documentation preview is available at https://preview.netcord.dev/342.

[Copilot]

Pull request overview

This PR addresses issue #341 where an explicitly configured autocomplete provider on an enum slash-command parameter was never invoked because enum parameters defaulted to a built-in choices provider. The update adjusts parameter/provider resolution to ensure autocomplete can be used for enums and enforces the Discord constraint that choices and autocomplete cannot be enabled simultaneously.

Changes:

• Refactors SlashCommandParameter initialization to prioritize explicitly specified AutocompleteProviderType over default enum choices handling.
• Adds a guard that throws when both a choices provider and an autocomplete provider are specified for the same parameter.
• Adds a test/repro module demonstrating enum autocomplete usage.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
Tests/NetCord.Test/ApplicationCommands/Commands.cs	Adds a repro command/module with an enum parameter using AutocompleteProviderType.
NetCord.Services/ApplicationCommands/SlashCommandParameter.cs	Refactors provider-selection logic to avoid “choices + autocomplete” conflicts and to allow enum autocomplete.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

[AraHaan]

Lmk when this is ready for merge.

[AraHaan]

I see that there is a new test failure now.

[KubaZ2]

I see that there is a new test failure now.

Yeah, I was moving code from my laptop. I need to make a big refactor to make it pass. Basically they fail because I throw InvalidOperationException instead of InvalidDefinitionException and there is no easy way to change that.

[Copilot]

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

NetCord.Services/ApplicationCommands/SlashCommandGroupInfo.cs:45

• This constructor now participates in the autocomplete/definition validation changes, but it still throws InvalidOperationException when no subcommands are found. Elsewhere in ApplicationCommands (e.g., SlashCommandParameter and SubSlashCommandGroupInfo) invalid command definitions now throw InvalidDefinitionException. Consider switching this to InvalidDefinitionException for consistency and so callers can reliably catch definition errors.

        if (subCommands.Count == 0)
            throw new InvalidOperationException($"No sub commands found in '{type.FullName}'.");

[Copilot]

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (1)

NetCord.Services/InvalidDefinitionException.cs:20

• GetMemberName returns only member.Name when DeclaringType is null (e.g., for top-level Type instances), which drops the namespace and makes InvalidDefinitionException messages less actionable. Consider special-casing Type to use type.FullName (fallback to type.Name) so error output includes the full type name.

    private static string GetMemberName(MemberInfo member)
    {
        var declaringType = member.DeclaringType;
        return declaringType is null ? member.Name : $"{declaringType.FullName}.{member.Name}";
    }

[Copilot]

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated no new comments.