bug fix: constrain cuda.core test installs to the requested CTK minor#1921
Open
rwgk wants to merge 2 commits intoNVIDIA:mainfrom
Open
bug fix: constrain cuda.core test installs to the requested CTK minor#1921rwgk wants to merge 2 commits intoNVIDIA:mainfrom
rwgk wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
Keep the core test environment aligned with the matrix-selected CUDA toolkit so pip does not resolve a newer runtime and invalidate the job coverage. Made-with: Cursor
Centralize the core wheel target selection so both install modes share one pip invocation while preserving when the published cuda.bindings extra is requested. Made-with: Cursor
rwgk
added
P0
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Collaborator
Author
|
/ok to test |
|
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xref: #1851 (comment)
Fix latent bug discovered while reviewing #1851 with the team.
Without the explicit
cuda-toolkit==${CUDA_VER_MINOR}.*pin,pipcan satisfy the broad major-version requirements with a newer CUDA Toolkit minor than the one selected by the CI matrix. In practice, that can either pull a newer nvidia-cuda-runtime than the local CTK provides or make the wheel-backed job silently test the wrong CTK minor, reducing the value of the matrix and masking minor-version-specific regressions.Changes
cuda-toolkitdependency inci/tools/run-teststo the matrix-selected CUDA toolkit minor forcuda.coretest installsWHL_EXTRA, only adding thecu${TEST_CUDA_MAJOR}extra when the run needs publishedcuda-bindings