[no-ci] check_spdx.py: require explicit license decisions for top-level paths and related cleanup#1913
Conversation
…CTED_LICENSE_IDENTIFIERS
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
We agreed to move it the benchmarks to |
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
|
Forensics note on this PR I dug into why The key point is that GitHub restored this PR branch exactly as GitHub last saw it at merge time. The restored branch I also recovered a previously local-only branch tip with additional follow-up commits (c656fba, 8b80715, 3f86b82, c31b4fc) that never made it to GitHub, so they were not part of the merged PR. I pushed that recovered history to The practical result is that the later work to make the top-level SPDX decisions explicit, handle the mixed-license |
GitHub merged PR 1913 before the later local commits were pushed, so replay the recovered SPDX policy follow-ups and related license fixes here. Context: #1913 (comment) Made-with: Cursor
Accident note
The PR description below does not match what was actually merged into
mainin a8805e5.GitHub merged the earlier branch state ending at c719fce, which is what GitHub restored for
rwgk:expected_license_identifiers_cont. The later follow-up changes described below were not pushed due to an unknown oversight.Those later changes are now preserved for reference on
rwgk:expected_license_identifiers_cont_recovered(see comment below for more details). Please read the remainder of this PR description as describing that recovered branch, not the merged result onmain.The missing commits were added to #1948 (comment) (needed there to guide fixing license identifiers).
Follow-on to PR #1897
Summary
Enforce an explicit SPDX license identifier for every top-level directory in the repository, so new paths can't slip in without a reviewed license decision.
Keep top-level files on an explicit default of
Apache-2.0.Continue to accommodate special cases, but treat them as exceptions we want to minimize rather than the default mechanism.
Update
cuda_bindings/pixi.tomltoLicenseRef-NVIDIA-SOFTWARE-LICENSE.Fix the current non-benchmark special cases by updating
.coveragerccuda_python_test_helpers/cuda_python_test_helpers/nvvm_bitcode.pytoolshed/build_static_bitcode_input.pytoolshed/dump_cutile_b64.pyto
Apache-2.0.Keep
cuda_bindings/benchmarks/as the only remaining special cases for now; those mixed-license cases will be handled in follow-on PRs (see comment below).Technical details
toolshed/check_spdx.pywith explicitTOP_LEVEL_DIRS_LICENSE_IDENTIFIERSandSPECIAL_CASE_LICENSE_IDENTIFIERSmappings.