Conversation
Signed-off-by: Jonathan Mitchell <jomitchell@ipp1-1334.ipp1a1.colossus.nvidia.com>
Greptile SummaryThis PR adds a standalone GEMM benchmark tool ( Three issues were flagged in earlier review rounds (FP8Block silently absent from shape mode, a dead Confidence Score: 4/5Safe to merge after addressing the open issues from prior review threads; the new chart-inconsistency finding is P2 but worth fixing before finalising the guide. Three P2 issues from prior review threads remain open (FP8Block absent from shape mode is the most user-visible). The new finding — the plot ignoring measured Dgrad when --verify-dgrad is used — is also P2 but contributes to incorrect figures in the guide. No P0/P1 blocking issues. Score is 4 rather than 5 because of the cumulative unresolved P2s, one of which (FP8Block omission) is advertised functionality that silently doesn't work. benchmarks/gemm/benchmark_gemm.py — FP8Block in shape mode, dead condition, docstring mismatch (prior threads), and chart/dgrad inconsistency (this pass). Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[python benchmark_gemm.py] --> B{Mode?}
B -- "--hidden_size etc." --> C[Model Config Mode\nrun_model_config_benchmarks]
B -- "--shapes or default" --> D[Shape Mode\nrun_benchmarks]
B -- "--profile" --> E[Nsight Profile Mode\nrun_benchmarks with single shape]
C --> F[compute_gemm_shapes\nFprop / Dgrad / Wgrad]
F --> G[_benchmark_single_shape\nBF16 + FP8Block + MXFP8 + NVFP4]
G --> H{--verify-dgrad?}
H -- Yes --> I[Benchmark Dgrad shapes\ndgrad_results measured]
H -- No --> J[Dgrad approximated as Fprop x2]
I --> K[Print per-layer summary\nuses measured times]
J --> K
K --> L[create_model_config_plot\nalways uses Fprop x2 for chart]
D --> M[benchmark_bf16\nbenchmark_fp8 MXFP8\nbenchmark_fp4 NVFP4]
M --> N[create_plot\nTFLOPS bar chart]
E --> D
Reviews (3): Last reviewed commit: "fixes tests" | Re-trigger Greptile |
| results: dict[str, list[float]] = {"BF16": [], "MXFP8": [], "NVFP4": []} | ||
| time_results: dict[str, list[float]] = {"BF16": [], "MXFP8": [], "NVFP4": []} | ||
|
|
||
| has_blackwell = is_blackwell_available() | ||
| run_fp8 = include_fp8 and TE_AVAILABLE | ||
| run_fp4 = include_fp4 and TE_AVAILABLE and has_blackwell |
There was a problem hiding this comment.
FP8Block silently omitted in shape mode
run_benchmarks() (used for both default square-shape benchmarks and explicit --shapes invocations) never calls benchmark_fp8_block / benchmark_fp8_block_prequantized. The results dict is initialized with only "BF16", "MXFP8", and "NVFP4", and the function has no include_fp8_block parameter — so the --no-fp8-block flag parsed in main() is only forwarded to run_model_config_benchmarks (line 1579) and has no effect here.
Users who run the tool in shape mode (no model-config flags) will silently receive BF16/MXFP8/NVFP4 data only, even though the module docstring advertises "BF16, FP8 Block, MXFP8, and NVFP4 precisions."
To fix, add include_fp8_block: bool = True to run_benchmarks, initialise results["FP8Block"] = [], select fp8_block_fn the same way model-config mode does, and forward the flag from main().
| color=op_color, | ||
| alpha=0.9, | ||
| label=f"{op_label} (Fprop+Dgrad)" if i == 0 or True else "", | ||
| ) | ||
| ax.bar( | ||
| x, | ||
| wgrad_ms, | ||
| bar_width, | ||
| bottom=all_fprop_total + total_wgrad_bottom, | ||
| color=op_color, | ||
| alpha=0.5, | ||
| label=f"{op_label} (Wgrad)" if i == 0 or True else "", | ||
| ) |
There was a problem hiding this comment.
Dead condition
if i == 0 or True always evaluates to True
Both label= expressions use if i == 0 or True, which unconditionally takes the True branch. This is dead code — or True makes the condition tautological. The intent was likely either True (always label, which is fine for a stacked bar chart) or if i == 0 (label only the first series). Clean it up to express intent clearly:
| color=op_color, | |
| alpha=0.9, | |
| label=f"{op_label} (Fprop+Dgrad)" if i == 0 or True else "", | |
| ) | |
| ax.bar( | |
| x, | |
| wgrad_ms, | |
| bar_width, | |
| bottom=all_fprop_total + total_wgrad_bottom, | |
| color=op_color, | |
| alpha=0.5, | |
| label=f"{op_label} (Wgrad)" if i == 0 or True else "", | |
| ) | |
| label=f"{op_label} (Fprop+Dgrad)", |
and
| color=op_color, | |
| alpha=0.9, | |
| label=f"{op_label} (Fprop+Dgrad)" if i == 0 or True else "", | |
| ) | |
| ax.bar( | |
| x, | |
| wgrad_ms, | |
| bar_width, | |
| bottom=all_fprop_total + total_wgrad_bottom, | |
| color=op_color, | |
| alpha=0.5, | |
| label=f"{op_label} (Wgrad)" if i == 0 or True else "", | |
| ) | |
| label=f"{op_label} (Wgrad)", |
| * **profiler** -- ``torch.profiler`` (CUPTI) kernel timestamps. | ||
| Only the matched GEMM compute kernels (nvjet, xmma, cutlass, cublas) | ||
| are summed, giving a kernel-only measurement. | ||
|
|
There was a problem hiding this comment.
Docstring lists "cublas" but the pattern tuple uses "gemm" instead
The module docstring (line 19) lists the matched kernel patterns as (nvjet, xmma, cutlass, cublas), but GEMM_KERNEL_PATTERNS at line 70 is ("gemm", "nvjet", "xmma", "cutlass") — "cublas" is absent and "gemm" was added in its place. In practice "gemm" does catch cuBLAS kernels (their names contain gemm), so the behaviour is correct, but the docstring is inaccurate and may confuse users auditing kernel coverage.
| * **profiler** -- ``torch.profiler`` (CUPTI) kernel timestamps. | |
| Only the matched GEMM compute kernels (nvjet, xmma, cutlass, cublas) | |
| are summed, giving a kernel-only measurement. | |
| * **profiler** -- ``torch.profiler`` (CUPTI) kernel timestamps. | |
| Only the matched GEMM compute kernels (gemm, nvjet, xmma, cutlass) | |
| are summed, giving a kernel-only measurement. |
Signed-off-by: Jonathan Mitchell <jomitchell@ipp1-1334.ipp1a1.colossus.nvidia.com>
|
Hi @jomitchellnv, I see that this PR is open, but "Documentation" job is failing. If you fix it, please ping me and I'll review it. |
Signed-off-by: Jonathan Mitchell <jomitchell@ipp1-1334.ipp1a1.colossus.nvidia.com>
Description
Adds a GEMM profiling guide to the Transformer Engine documentation and a companion benchmark tool. The guide
explains how to derive all 12 per-layer GEMM shapes (Fprop, Dgrad, Wgrad) from transformer model
hyperparameters, benchmark them across precisions (BF16, FP8 Block, MXFP8, NVFP4), and interpret the resulting
speedup estimates.
The benchmark tool supports two modes: model config mode (derives shapes automatically from hidden_size,
intermediate_size, etc.) and manual shape mode (explicit MxKxN triplets). It measures both autocast performance
(realistic end-to-end with quantization overhead) and pre-quantized kernel-only throughput, using CUDA events
or torch.profiler timing backends.
Type of change
Changes
Add benchmarks/gemm/benchmark_gemm.py — standalone GEMM benchmark tool supporting BF16, FP8 Block, MXFP8, and
NVFP4 precisions with autocast and pre-quantized modes, CUDA event and torch.profiler timing, Nsight Systems
integration, and bar-chart output
Add docs/features/low_precision_training/gemm_profiling/gemm_profiling.rst — documentation covering GEMM
shape derivation from model configs, forward/backward pass shape conventions, precision mapping per GEMM pass,
speedup calculation methodology, and a worked example on B300
Add benchmark result plots (img/model_config_speedup.png, img/model_config_speedup_prequant.png)
Update docs/features/low_precision_training/index.rst toctree to include the new guide
Please list the changes introduced in this PR:
Change A
Change B
Checklist: