Skip to content

add configurable timeout for image transfer to gateway containerd#914

Merged
drew merged 1 commit intoNVIDIA:mainfrom
tmckayus:tmckay/large-transfer-timeout
Apr 22, 2026
Merged

add configurable timeout for image transfer to gateway containerd#914
drew merged 1 commit intoNVIDIA:mainfrom
tmckayus:tmckay/large-transfer-timeout

Conversation

@tmckayus
Copy link
Copy Markdown
Contributor

Summary

The transfer of very large sandbox images to containerd can timeout depending on the size of the image and the speed of the local host.

Changes

  • crates/openshell-bootstrap/src/docker.rs — add connect_local_for_large_transfers() helper plus a DEFAULT_LARGE_TRANSFER_TIMEOUT_SECS constant; reads OPENSHELL_DOCKER_TIMEOUT_SECS so the timeout can be tuned per host/image without a rebuild. Default is 3600s.
  • crates/openshell-bootstrap/src/build.rs — route the sandbox create --from image sideload through the new helper so docker save streams don't trip bollard's 120 s default.
  • crates/openshell-bootstrap/src/lib.rs — same helper for the OPENSHELL_PUSH_IMAGES component-deploy path, for consistency.

Testing

Tested with large and small image files manually to verify configurable timeout is effective with no regression
Did not include any unit test.

@tmckayus tmckayus requested a review from a team as a code owner April 22, 2026 00:46
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

All contributors have signed the DCO ✍️ ✅
Posted by the DCO Assistant Lite bot.

@drew drew self-assigned this Apr 22, 2026
@drew
Copy link
Copy Markdown
Collaborator

drew commented Apr 22, 2026

This PR looks good to me. Just some issues with code formatting and need to sign DCO. As a FYI we'll be moving off this k3s approach and use docker more natively on the host which should additionally resolve the issue.

Ticket for this work is here: #873. Hoping to land this by the end of the week.

@tmckayus
Copy link
Copy Markdown
Contributor Author

I have read the DCO document and I hereby sign the DCO.

the transfer of very large sandbox images to containerd can
timeout depending on the size of the image and the speed of
the local host.

Made-with: Cursor
@tmckayus tmckayus force-pushed the tmckay/large-transfer-timeout branch from 49f5294 to 01a34e3 Compare April 22, 2026 13:49
@drew drew merged commit 78b685e into NVIDIA:main Apr 22, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants