CCM-16489: Add letter authoring e2e tests#930
Merged
Conversation
bcfb235 to
5de6a57
Compare
5cb1262 to
5a8a9d4
Compare
5a8a9d4 to
aa1ec8e
Compare
alexnuttall
reviewed
May 1, 2026
alexnuttall
reviewed
May 1, 2026
alexnuttall
reviewed
May 1, 2026
alexnuttall
reviewed
May 1, 2026
alexnuttall
reviewed
May 1, 2026
alexnuttall
reviewed
May 1, 2026
alexnuttall
reviewed
May 1, 2026
alexnuttall
reviewed
May 1, 2026
alexnuttall
reviewed
May 1, 2026
alexnuttall
reviewed
May 1, 2026
alexnuttall
reviewed
May 1, 2026
alexnuttall
reviewed
May 1, 2026
alexnuttall
reviewed
May 5, 2026
alexnuttall
reviewed
May 5, 2026
alexnuttall
reviewed
May 5, 2026
alexnuttall
reviewed
May 5, 2026
chris-elliott-nhsd
previously approved these changes
May 5, 2026
alexnuttall
previously approved these changes
May 5, 2026
chris-elliott-nhsd
previously approved these changes
May 6, 2026
14a1518
chris-elliott-nhsd
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
for each letter type
templateStorageHelper. (Saw this in the existing pdf-letter e2e tests)One test covers off invalid template scenario (missing address).
Added arabic and large print letters.
Tests succeeding locally:

Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.
Description
Raising draft to check CI pipeline status
for each letter type
templateStorageHelper. (Saw this in the existing pdf-letter e2e tests)Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.